- Issue created by @Spokje
- last update
10 months ago 30,158 pass - @spokje opened merge request.
- Status changed to Needs review
10 months ago 11:27am 15 September 2023 - Assigned to Spokje
- Status changed to Needs work
10 months ago 1:20pm 15 September 2023 - last update
10 months ago 30,158 pass - Issue was unassigned.
- Status changed to Needs review
10 months ago 1:38pm 15 September 2023 - 🇺🇸United States smustgrave
If I search for in empty\\(\\) always exists and is not falsy find about 39 instances. Should they addressed?
- 🇳🇱Netherlands Spokje
They should and will. just not in here.
There are a few smaller ones about "empty not falsy" coming up and after that I am preparing one big issue for the rest of them that have the same, general problem.
These three ones are part of the smaller ones that are specific and don't fit that same, general problem.
- Status changed to RTBC
10 months ago 3:28pm 15 September 2023 - last update
10 months ago 30,161 pass - last update
9 months ago 30,156 pass, 2 fail - last update
9 months ago 30,168 pass - last update
9 months ago 30,205 pass - last update
9 months ago 30,208 pass - last update
9 months ago 30,362 pass - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
9 months ago Not currently mergeable. - Status changed to Needs work
9 months ago 2:21am 30 September 2023 - last update
9 months ago Custom Commands Failed - last update
9 months ago 30,360 pass - Status changed to Needs review
9 months ago 6:41am 30 September 2023 - 🇳🇱Netherlands Spokje
TIL:
- Merge conflicts can be exiting
- Downscaling due to 2/3 of the original problem already being fixed elsewhere creates a lot of noise when the person behind keyboard tries to make the IS correct again.Back to NR.
- Status changed to RTBC
9 months ago 1:02pm 30 September 2023 - 🇬🇧United Kingdom longwave UK
Nice easy fix here, glad that we have PHPStan to spot such things.
- Status changed to Fixed
9 months ago 6:59pm 30 September 2023 - 🇺🇸United States xjm
I confirmed the issue reading
core/tests/Drupal/FunctionalJavascriptTests/Core/MachineNameTest.phplocally. Very nice cleanup. In PHPStan we trust!Adding credit for @smustgrave for the scope check. @Spokje's answer makes sense, but it's good to ask the question if the reason for the current scope is not already documented.
Committed to 11.x. I also tried to backport it to 10.1.x since it's a patch-eligible test code cleanup, but there were more merge conflicts in the baseline. (Not exciting ones, just "regenerate the baseline" ones.) That seemed maybe not worth the effort, so leaving fixed against 11.x. Thanks everyone!
Automatically closed - issue fixed for 2 weeks with no activity.