Remove redundant if (empty($machine_name_1_value))-statement in MachineNameTest::testMachineName

If I search for in empty\\(\\) always exists and is not falsy find about 39 instances. Should they addressed?

They should and will. just not in here.

There are a few smaller ones about "empty not falsy" coming up and after that I am preparing one big issue for the rest of them that have the same, general problem.

These three ones are part of the smaller ones that are specific and don't fit that same, general problem.

Thanks for clarifying!

LGTM

This has some exciting merge conflicts.

TIL:

- Merge conflicts can be exiting
- Downscaling due to 2/3 of the original problem already being fixed elsewhere creates a lot of noise when the person behind keyboard tries to make the IS correct again.

Back to NR.

Nice easy fix here, glad that we have PHPStan to spot such things.

I confirmed the issue reading core/tests/Drupal/FunctionalJavascriptTests/Core/MachineNameTest.php locally. Very nice cleanup. In PHPStan we trust!

Adding credit for @smustgrave for the scope check. @Spokje's answer makes sense, but it's good to ask the question if the reason for the current scope is not already documented.

Committed to 11.x. I also tried to backport it to 10.1.x since it's a patch-eligible test code cleanup, but there were more merge conflicts in the baseline. (Not exciting ones, just "regenerate the baseline" ones.) That seemed maybe not worth the effort, so leaving fixed against 11.x. Thanks everyone!

Spokje → closed merge request !4794

Automatically closed - issue fixed for 2 weeks with no activity.