Fix assertion issue in automated tests

Created on 14 September 2023, about 1 year ago
Updated 27 September 2023, about 1 year ago

Problem/Motivation

I have noticed that in all of the tests for photoswipe whenever there is a call to the method $session->waitForElementVisible() it is missing the appropriate $this->assertNotNull() assertion around it. If this assertion is not made, the $session->waitForElementVisible() method will not throw an error and continue even if the element is not visible after the specified timeout. This might have implications like tests turning out OK when in reality they are not.

Steps to reproduce

Proposed resolution

Wrap all calls to this method in the $this->assertNotNull() assertion.
Example: $this->assertNotNull($session->waitForElementVisible('css', '.some-class'));

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

5.0

Component

Code

Created by

🇩🇪Germany lrwebks Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024