- Issue created by @solideogloria
- Merge request !63Issue #3271896 by eiriksm, acbramley, VladimirAus, Johnny Santos,... → (Closed) created by solideogloria
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago 87 pass - Status changed to Needs review
about 1 year ago 4:39pm 1 April 2024 Everything is backwards compatible. Queued links will not be checked if unpublished, and unpublished links will not be queued anymore. Links tested manually with
->check()
will still be checked, even if unpublished. The function returns a Promise, and returning early would break BC and require more changes.I created a test for this fix. There is a failing test but it's also failing on dev, so it's not related to these changes.
Also, could a maintainer please set 2.0.x as the default branch?
solideogloria → changed the visibility of the branch 3386764-links-with-test to hidden.
solideogloria → changed the visibility of the branch 3386764-links-with-test to active.
- last update
about 1 year ago 87 pass - Status changed to RTBC
12 months ago 5:57pm 19 April 2024 - 🇨🇦Canada joelpittet Vancouver
I echo what @solideogloria said in #6 about the default branch but you can change it retroactively.
Anyways this looks great and is what I'd expect it to be doing, it's ready to be committed.
- First commit to issue fork.
- last update
12 months ago 87 pass -
eiriksm →
committed d76c0c5b on 2.0.x authored by
solideogloria →
Issue #3386764 by solideogloria, joelpittet: Unpublished links (test...
-
eiriksm →
committed d76c0c5b on 2.0.x authored by
solideogloria →
- Status changed to Fixed
12 months ago 6:19pm 19 April 2024 - 🇳🇴Norway eiriksm Norway
I think I managed to change the default branch now as well ✌️
Automatically closed - issue fixed for 2 weeks with no activity.