Contrib.social

Revision object is returned instead of revision id due to core type upcasting change.

Open on Drupal.org →
Created on 12 September 2023, over 1 year ago
Updated 21 June 2024, 6 months ago

Problem/Motivation

Drupal core 9.3 updated the typecasting for the node_revision route parameter → which means it's a fully fledged object now. The code in this module for getting the entity is using code that thinks it's the revision id, a numeric value, which then throw this error:

TypeError: Illegal offset type in Drupal\Core\Entity\ContentEntityStorageBase->loadRevision() (line 636 of core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php).

Steps to reproduce

  1. Install the module
  2. Create a node with revisions
  3. Click on the Revisions tab, click to view one of the revisions, observe WSOD

Proposed resolution

See attached patch.

Remaining tasks

User testing

🐛 Bug report
Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India sahilgidwani Jaipur

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @sahilgidwani
  • Comment over 1 year ago →
    🇮🇳India sahilgidwani Jaipur
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India sahilgidwani Jaipur
  • Issue was unassigned.
  • Comment 6 months ago →
    🇨🇦Canada franceslui

    @sahilgidwani Thank you for submitting the patch in your comment #2. I have reviewed it and found that it worked correctly.

    Since node_revision_load is deprecated in Drupal 10.1.0 and will be removed in Drupal 11.0.0, I have submitted a new patch that uses \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.

  • Status changed to RTBC 6 months ago
  • Comment 6 months ago →
    🇨🇦Canada joelpittet Vancouver

    Thank you both, this issue is indeed major as it is a WSOD for content editors. I have reviewed the patches and tested it out and it works well.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024