Copy less files around in ComponentsIsolatedBuildTest

Ran this on my local too

Before

After

Shaved almost 10 minutes off!

We can still use a data provider here. It's just that the finder still actaully copies the entire codebase.

The patch attached will be as fast as #5 and avoids copying the entire codebase and just does the components. The problem is caused by the fact that \Symfony\Component\Finder\Finder::in() does not work the way the test thinks it does. It does an array merge so even though the test in HEAD does ->in($this->getDrupalRoot() . static::$componentsPath) we still copy over the entire codebase.

It's not as fast as #5, it's much faster :)

PHPUnit 9.6.8 by Sebastian Bergmann and contributors.

Testing Drupal\BuildTests\Composer\Component\ComponentsIsolatedBuildTest
........................                                          24 / 24 (100%)

Time: 02:27.754, Memory: 10.00 MB

OK (24 tests, 24 assertions)

real	2m27.977s
user	1m49.650s
sys	0m36.118s

Build tests taking a total of 4m27s now https://git.drupalcode.org/project/drupal/-/jobs/82874

Locally I see a massive difference... compare

Testing Drupal\BuildTests\Composer\Component\ComponentsIsolatedBuildTest
........................                                          24 / 24 (100%)

Time: 07:18.378, Memory: 35.50 MB

OK (24 tests, 24 assertions)

________________________________________________________
Executed in  438.98 secs    fish           external
   usr time   56.46 secs    0.09 millis   56.46 secs
   sys time  355.37 secs    6.57 millis  355.37 secs

Testing Drupal\BuildTests\Composer\Component\ComponentsIsolatedBuildTest
........................                                          24 / 24 (100%)

Time: 00:13.337, Memory: 16.00 MB

OK (24 tests, 24 assertions)

________________________________________________________
Executed in   14.07 secs    fish           external
   usr time    5.74 secs    0.09 millis    5.74 secs
   sys time    5.87 secs    7.43 millis    5.86 secs

:D

The last submitted patch, 7: 3386479-7.patch, failed testing. View results →

Known random test failure ( 🐛 [random test failure] MenuUiTest::testMenuAdministration Active ), back to RTBC.

Committed and pushed dd62dc1e84 to 11.x and 78e5aa8c58 to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.