Comply with Drupal coding standards (3) (Stylelint)

Hi @yas, I fixed the stylelint error according to the Stylelint and css standards.

Please review and verify.

@shubhanm_jain

Thank you for fixing the coding standards. Unfortunately, main.css is automatically generated by SCSS tool so that we should take a look assets/scss directory. Probably we should exclude the main.css file from stylelint check from .gitlab-ci.yml at 💬 Add a .gitlab-ci.yml file Needs work .

glyphicons.css should be fine.

Thanks

Hi @yas, you are right you need to exclude the main.css file from stylelint check from .gitlab-ci.yml. And add scss stylelint check.

I have corrected the scss according to the stylelint and created PR for it.

Please review and verify.

@shubham_jain

Thank you for the fixes. I ran d.o's GitLab CI w/ your patch and here is the result:

https://git.drupalcode.org/project/rigel/-/jobs/87913

$ yarn --silent --cwd $_WEB_ROOT/core stylelint --formatter verbose --config ./.stylelintrc.json ../modules/custom/**/*.css --color || true
../modules/custom/rigel/assets/css/main.css
  67:9  ✖  Expected "url("https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;1,300;1,400;1,500&display=swap")" to be ""https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;1,300;1,400;1,500&display=swap""  import-notation
 324:1  ✖  Unexpected vendor-prefixed at-rule "@-webkit-keyframes"                                                                                                                                                                                                        at-rule-no-vendor-prefix
 331:1  ✖  Unexpected vendor-prefixed at-rule "@-moz-keyframes"                                                                                                                                                                                                           at-rule-no-vendor-prefix
 338:1  ✖  Unexpected vendor-prefixed at-rule "@-ms-keyframes"                                                                                                                                                                                                            at-rule-no-vendor-prefix
 345:1  ✖  Unexpected vendor-prefixed at-rule "@-o-keyframes"                                                                                                                                                                                                             at-rule-no-vendor-prefix
5 problems (5 errors, 0 warnings)

There were no errors such as Unexpected unknown at-rule "@include" at-rule-no-unknown but there look the other errors that stylelint cannot recognize.

If we ignore those errors, what about the first one:

Expected "url("https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;1,300;1,400;1,500&display=swap")" to be ""https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;1,300;1,400;1,500&display=swap"" import-notation

Can you figure it out?

Thanks

Hi @yas,
this error Unexpected vendor-prefixed at-rule "@-webkit-keyframes" is to be ignored and will see to it if can be resolved.

Expected "url("https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;1,300;1,400;1,500&display=swap")" to be ""https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;1,300;1,400;1,500&display=swap"" import-notation

I know what to do and will push updated code.

Solved those error.

@yas, those errors were not coming in my local setup so please test and verify.

@shubham_jain

Thank you for the update. I ran d.o's GitLab CI w/ your patch and here is the result:

https://git.drupalcode.org/project/rigel/-/jobs/93411

The following error wasn't fixed:

Expected "url("https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;1,300;1,400;1,500&display=swap")" to be ""https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;1,300;1,400;1,500&display=swap"" import-notation

So I posted my comments.

Thanks

Hi @yas, thanks for the feedback. I have resolved all the threads and have made changes directly through git interface.
So, please review and verify.

@shubham_jain

Thank for the update. Thank you for the fixes. I ran d.o's GitLab CI w/ your patch and here is the result:

https://git.drupalcode.org/project/rigel/-/jobs/100137

It looks url import notation was ignored but still the error Unexpected vendor-prefixed at-rule "@-webkit-keyframes" at-rule-no-vendor-prefix has not been fixed.

Hi @yas, please review updated MR.

@shubham_jain, Thanks for the work on this patch. I have a question about the last commit

For this: https://git.drupalcode.org/project/rigel/-/merge_requests/42/diffs?commi..., did you make the corresponding SCSS change as well?

@baldwinlouie

Thank you for your review. Let us change the status to Needs work.

@shubham_jain

What do you think about @baldwinlouie's comment?

@baldwinlouie

Thank you for your review. I forgot to do those changes but now I have fixed that. Please review.

@shubham_jain

Thank for the update. Thank you for the fixes. I ran d.o's GitLab CI w/ your patch and the stylelint test has been passed successfully at https://git.drupalcode.org/project/rigel/-/jobs/106707

@baldwinlouie

What do you think?

Thanks

@shubham_jain Thanks for the great patch. It looks good to me now .

@baldwinlouie

Thank you for your review.

@shubham_jain

Thank you for your efforts. I'll merge the patch to 6.x, and close this issue as Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.