- Issue created by @Grevil
- last update
over 1 year ago 1 pass, 2 fail - @grevil opened merge request.
- Status changed to Needs review
over 1 year ago 12:47pm 8 September 2023 - 🇩🇪Germany Grevil
Done, please review!
I know, that at least for chromium based browsers, only "name", "icons", "start_url" and "display" is required. But all the other required fields, here, are set indirectly. For example, if "scope" is not set, the scope will be based on the "start_url". Or if "theme_color" is not set, it will fall back to #ffffff. So making these fields required and setting the fallback value inside the pwa.config.yml only makes sense here. So the user knows, what setting he is actual using.
- last update
over 1 year ago 9 pass - last update
over 1 year ago 9 pass - Status changed to Needs work
over 1 year ago 12:57pm 8 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
Please do a manual test (running the update hook and testing the settings) once finished, then it should be fine! :)
- last update
over 1 year ago 9 pass - last update
over 1 year ago 9 pass - Status changed to Needs review
over 1 year ago 1:43pm 8 September 2023 - 🇩🇪Germany Grevil
Tested the update hook, works great! Please rereview!
- last update
over 1 year ago 9 pass -
Anybody →
committed abc66757 on 2.x authored by
Grevil →
Issue #3386112 by Grevil, Anybody: Rename "site_name" to actual "name"...
-
Anybody →
committed abc66757 on 2.x authored by
Grevil →
- Status changed to Fixed
over 1 year ago 1:50pm 8 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.