- Issue created by @Anybody
- π©πͺGermany Anybody Porta Westfalica
We could also think about automating the migration to the core settings releasing a 3.x version, which transfers the configuration from this module to the
file.settings
core config and afterwards uninstalls itself. What do you think?Other deprecated modules which were merged into core or other contrib modules, did similar in the past.
- π©πͺGermany Grevil
We could also think about automating the migration to the core settings releasing a 3.x version, which transfers the configuration from this module to the file.settings
Let's do that in a follow-up issue! If needed!
- @grevil opened merge request.
- Status changed to Needs review
about 1 year ago 1:11pm 26 October 2023 - π©πͺGermany Grevil
Set the module deprecated in favour of the core functionality, at least once Drupal 9 is EOL
I don't think we should do that, since Drupal 10.0.x and Drupal 10.1.x will then be still in use. These instances will also have the deprecation notice then if we use the
lifecycle: deprecated lifecycle_link: xxx
approach in the info.yml. This can be quite confusing.
I guess the current implementation should be enough. Otherwise we could create a ^10.2.x only version and use the lifecycle properties, but I don't think that is necessary.
Please review!
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
about 1 year ago Not currently mergeable. - Status changed to Needs work
about 1 year ago 1:15pm 26 October 2023 - π©πͺGermany Anybody Porta Westfalica
@Grevil: Thanks, just one comment for clarification on the module overview page.
Afterwards RTBC!
- π©πͺGermany Anybody Porta Westfalica
Could you ping the last active maintainer please to take a look at this issue? No maintainer activity here yet.
Also a note should be added to the module page and the module status should be changed.
- Status changed to Needs review
about 1 year ago 1:18pm 26 October 2023 - π©πͺGermany Grevil
I send https://www.drupal.org/u/adubovskoy β an email!
- Status changed to RTBC
about 1 year ago 1:27pm 26 October 2023 - π©πͺGermany Anybody Porta Westfalica
Perfect!
@Maintainers: Also a note should be added to the module page and the module status should be changed.
- First commit to issue fork.
-
adubovskoy β
committed a9857cbf on 2.0.x authored by
Grevil β
Issue #3385940 by Grevil, Anybody: Deprecate this module in favor of...
-
adubovskoy β
committed a9857cbf on 2.0.x authored by
Grevil β
- Status changed to Fixed
about 1 year ago 4:37pm 26 October 2023 - π²πͺMontenegro adubovskoy Budva
@Grevil, @Anybody thank you for your input! The module page is updated.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
9 months ago 7:34pm 5 April 2024 - πΊπΈUnited States joegl
If we're uninstalling this module and using the new "Sanitize filenames" settings at /admin/config/media/file-system, I assume we'd want to enable all the options and leave the Replacement Character as the dash? Thanks!