Deprecate this module in favor of core functionality (>=10.2)

Created on 7 September 2023, 10 months ago
Updated 5 April 2024, 3 months ago

Problem/Motivation

Drupal Core (10.2) now finally has built-in filename sanitation! See CR: https://www.drupal.org/node/2972665 β†’

I guess we should:

  1. Inform users of this module in the status report if they use Drupal >= 10.2.0 with a link to the change-record
  2. Inform potential users of this module on the module page and link to the Change record and issue
  3. Set the module deprecated in favour of the core functionality, at least once Drupal 9 is EOL

With the many core improvements happening, I think it's works to let users know and tell them they can uninstall the module, once they configured their installation accordingly.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Documentation

Created by

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    We could also think about automating the migration to the core settings releasing a 3.x version, which transfers the configuration from this module to the file.settings core config and afterwards uninstalls itself. What do you think?

    Other deprecated modules which were merged into core or other contrib modules, did similar in the past.

  • πŸ‡©πŸ‡ͺGermany Grevil

    We could also think about automating the migration to the core settings releasing a 3.x version, which transfers the configuration from this module to the file.settings

    Let's do that in a follow-up issue! If needed!

  • @grevil opened merge request.
  • Status changed to Needs review 8 months ago
  • πŸ‡©πŸ‡ͺGermany Grevil

    Set the module deprecated in favour of the core functionality, at least once Drupal 9 is EOL

    I don't think we should do that, since Drupal 10.0.x and Drupal 10.1.x will then be still in use. These instances will also have the deprecation notice then if we use the

    lifecycle: deprecated
    lifecycle_link: xxx
    

    approach in the info.yml. This can be quite confusing.

    I guess the current implementation should be enough. Otherwise we could create a ^10.2.x only version and use the lifecycle properties, but I don't think that is necessary.

    Please review!

  • Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 8 months ago
    Not currently mergeable.
  • πŸ‡©πŸ‡ͺGermany Grevil
  • Status changed to Needs work 8 months ago
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    @Grevil: Thanks, just one comment for clarification on the module overview page.

    Afterwards RTBC!

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Could you ping the last active maintainer please to take a look at this issue? No maintainer activity here yet.

    Also a note should be added to the module page and the module status should be changed.

  • Status changed to Needs review 8 months ago
  • πŸ‡©πŸ‡ͺGermany Grevil

    Done, please review again.

  • Status changed to RTBC 8 months ago
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Perfect!

    @Maintainers: Also a note should be added to the module page and the module status should be changed.

  • First commit to issue fork.
  • Status changed to Fixed 8 months ago
  • πŸ‡²πŸ‡ͺMontenegro adubovskoy Budva

    @Grevil, @Anybody thank you for your input! The module page is updated.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States joegl

    If we're uninstalling this module and using the new "Sanitize filenames" settings at /admin/config/media/file-system, I assume we'd want to enable all the options and leave the Replacement Character as the dash? Thanks!

Production build 0.69.0 2024