Social sharing email breaks if there is no current route

Created on 4 September 2023, 10 months ago

Updated 22 November 2023, 7 months ago

Problem/Motivation

Social sharing email link assumes that $routeMatch->getRouteName() is not null. This isn't always the case, eg during search indexing triggered via drush.

Steps to reproduce

Add {{ global_variables.social_sharing.email }} somewhere in a template that will get rendered during search indexing.

Proposed resolution

Test for $routeMatch->getRouteName() != NULL before using it.

Remaining tasks

Patch, tests.

🐛 Bug report

Status

Fixed

Version

2.2

Component

Code

Created by

🇸🇪Sweden erik.erskine

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @erik.erskine
Comment 10 months ago →
🇸🇪Sweden erik.erskine
Here's a rudimentary check that bails out if $routeMatch->getRouteName() is null.
Comment 8 months ago →
🇮🇪Ireland markconroy

Comment 8 months ago →

System Message

erik.erskine → authored 5772b2ae on 2.2.x

Issue #3385194 by erik.erskine, markconroy: Social sharing email breaks...

Status changed to Fixed 7 months ago10:52am 22 November 2023
Comment 7 months ago →
🇺🇦Ukraine voleger Ukraine, Rivne
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024