- Issue created by @rszrama
- ๐บ๐ฆUkraine marchuk.vitaliy Rivne, UA
vmarchuk โ made their first commit to this issueโs fork.
- last update
about 1 year ago 38 pass - @vmarchuk opened merge request.
- Status changed to Needs review
about 1 year ago 9:36am 5 September 2023 - ๐บ๐ธUnited States rszrama
Thanks for this. I made a few minor changes: changed the default to use advanced fraud signals and reversed the logic, removed the manual attachment of the Stripe library on the Card Element form (since it's already added globally), and set the version string on the library to just the numeric version (for simpler later comparison). I don't know exactly where we should support toggling on / off the advanced fraud signals, so I'll open a follow-up issue for that.
-
rszrama โ
committed 4606f885 on 8.x-1.x
Issue #3385061: Include the Stripe.js library on all front-end paths.
-
rszrama โ
committed 4606f885 on 8.x-1.x
- Status changed to Fixed
about 1 year ago 12:49am 20 September 2023 - ๐บ๐ธUnited States rszrama
No clue what happened with the MRs, so I'll try to delete 'em out. I just did a manual rebase / merge.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
3 months ago 8:20am 2 August 2024 - ๐ฎ๐ฑIsrael jsacksick
Even though this is almost a year old issue, just wanted to point here that we should have considered previous complaints since we used to include the library in all pages previously and if we had to reintroduce this for whatever reason, we should have provided a setting somewhere (even from settings.php, potentially off by default because of the previous complaints).
As pointed out ๐ Regression: Allow sites to opt out from global stripe js loading Active , this is a recommendation not a requirement.