- Issue created by @john pitcairn
- 🇮🇱Israel jsacksick
As I see it, the problem is you could have multiple Stripe payment gateways on your site (with potentially different conditions).
So a setting at the gateway level would mean loading all gateways, and checking if toggle is on on any of them (which isn't optimal).Alternative would be checking a setting flag... Like the following:
Settings::get('commerce_stripe_global_library_include', TRUE);
. (poor naming, wasn't inspired)Another option if you're really bothered by that is to use a
hook_module_implements_alter()
to unregister thehook_page_attachments()
implementation from Commerce Stripe.Also, we probably should have discussed this before re-adding the library to all pages, considering the issue linked / previous complaints.
- Assigned to TomTech
- Merge request !124Issue #3465365 by TomTech, john pitcairn, jsacksick: Regression: Allow sites... → (Merged) created by TomTech
- 65a70ac7 committed on 8.x-1.x
Issue #3465365 by TomTech, john pitcairn, jsacksick: Regression: Allow...
- 65a70ac7 committed on 8.x-1.x
- Status changed to Fixed
8 months ago 3:24am 13 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.