- Issue created by @sassafrass
- First commit to issue fork.
- @vasike opened merge request.
- Status changed to Needs review
over 1 year ago 9:19am 15 September 2023 - π·π΄Romania vasike Ramnicu Valcea
I agree that this module shouldn't add dependencies to Views ... as the Autocomplete is just extra functionality to existing Filters.
Probably It could be done manually, by "disabling" Use Autocomplete on every View and filter, but not ideal.
I found similar issue on View Unpublished module, which was also fixed.
https://www.drupal.org/project/view_unpublished/issues/2934157 βSo i just "stole" the solution there and created a MR ... as i think we need some testing before merge.
And it's about Remove views_autocomplete_filters dependency from Views.
- Alter Filter plugins, not views data.
- Update hook and on Uninstall.thanks @amaria for the solution
-
vasike β
committed 02ace429 on 8.x-1.x
Issue #3384650: Uninstalling Deletes Views - Remove dependencies -...
-
vasike β
committed 02ace429 on 8.x-1.x
-
vasike β
committed 2e846bc6 on 8.x-1.x
Issue #3384650: Uninstalling Deletes Views - Remove dependency - Alter...
-
vasike β
committed 2e846bc6 on 8.x-1.x
- π·π΄Romania vasike Ramnicu Valcea
MR merged. My tests worked. so closing.
please, feel free, if not done.
- Status changed to Fixed
about 1 year ago 10:06am 9 October 2023 - Status changed to Needs work
about 1 year ago 12:15pm 10 October 2023 - π©πͺGermany tobiasb Berlin
Some configs looks like this now. The fix is really small.
config/sync/views.view.moderated_content.yml ββββββββββββββββββ 7: dependencies: β ββββββββββββββββββ 7β 7β - workflows.workflow.draften_member 8β 8β - workflows.workflow.magazine_article 9β 9β module: 10β β - content_moderation 11β β - node 12β β - user 13β β - views_autocomplete_filters 14β β - views_bulk_operations β 10β 0: content_moderation β 11β 1: node β 12β 2: user β 13β 4: views_bulk_operations 15β 14β enforced: 16β 15β module: 17β 16β - content_moderation
- Status changed to Needs review
about 1 year ago 12:19pm 10 October 2023 -
vasike β
committed 6cabeb56 on 8.x-1.x authored by
tobiasb β
Issue #3384650 by tobiasb: Uninstalling Deletes Views - FollowUp
-
vasike β
committed 6cabeb56 on 8.x-1.x authored by
tobiasb β
-
vasike β
committed 053c68c2 on 2.0.x authored by
tobiasb β
Issue #3384650 by tobiasb: Uninstalling Deletes Views - FollowUp
-
vasike β
committed 053c68c2 on 2.0.x authored by
tobiasb β
- Status changed to Fixed
about 1 year ago 12:23pm 17 October 2023 - π·π΄Romania vasike Ramnicu Valcea
thanks a lot tobiasb ... pushed on both branches
i think we can close it.
Automatically closed - issue fixed for 2 weeks with no activity.