Button styling should not be visible if there is no text present in the button.

Open on Drupal.org →

Created on 31 August 2023, over 1 year ago

Updated 13 September 2023, over 1 year ago

Problem/Motivation

If there is no text in the button then button styling should not be visible on UI. Currently, there is no text in the button but button styling is visible, we can add a condition here- if the text is not present in the button then the button should not be visible on the UI

Steps to reproduce

Install the theme
Enable it
See cta link on the banner

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs work

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @shweta__sharma
Assigned to Vinayak.Ambig
Comment over 1 year ago →
🇮🇳India Vinayak.Ambig
First commit to issue fork.
@sakthi_dev opened merge request.
Status changed to Needs review over 1 year ago11:17am 7 September 2023
Comment over 1 year ago →
🇮🇳India sakthi_dev
Needs Review.
Issue was unassigned.
Comment over 1 year ago →
🇮🇳India Vinayak.Ambig
Comment over 1 year ago →
🇮🇳India Vinayak.Ambig
I have applied MR and Issue still persist. Currently there is no text in the button but button styling is visible. And also provided resolutions is not as per the prosed solutions.(condition here- if the text is not present in the button then the button should not be visible on the UI). So moving back to needs work. For reference Attached screenshot.

Steps followed
1. Drupal set up 9 and enabled robotic theme.
2. Verified the changes - no text in the button. still button styling is visible.

I’m working on it.
Status changed to Needs work over 1 year ago11:31am 13 September 2023
Comment over 1 year ago →
🇮🇳India Vinayak.Ambig

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024