- Issue created by @andrei.vesterli
- @andreivesterli opened merge request.
- Assigned to nick.murza
- Status changed to Needs review
over 1 year ago 2:22pm 29 August 2023 - Status changed to Needs work
over 1 year ago 2:27pm 29 August 2023 - πΊπΈUnited States smustgrave
Should add a gitlab file so these get caught early.
- π²π©Moldova andrei.vesterli Chisinau
Hi @ smustgrave
Thx for your input but this issue does not cover adding extra things like the Gitlab file. I assume, there needs to be another issue for that purpose.
p.s Besides, this particular issue has an assigned person and it is in review, please, do not update the status when it's not yet reviewed.
Regards,
Andrei - πΊπΈUnited States smustgrave
Adding a gitlab file is the suggestion we've been making for those credit farming phpcs fixes. But I don't pay much attention to this module so don't have much stack in if we add it.
- π²π©Moldova nick.murza Moldova
nick.murza β made their first commit to this issueβs fork.
-
nick.murza β
committed 8b4e5f45 on 1.x authored by
andrei.vesterli β
Issue #3384006 by andrei.vesterli: PHPStan fixes + other minor...
-
nick.murza β
committed 8b4e5f45 on 1.x authored by
andrei.vesterli β
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 2:58pm 29 August 2023 - Status changed to Fixed
over 1 year ago 3:12pm 29 August 2023