- Issue created by @lrwebks
- 🇩🇪Germany lrwebks Porta Westfalica
A possible naming structure could be the following:
- Every word within the page title sould be in uppercase (Add Project Wiki Entity Content)
- Menu names should be the same as page titles just shortened (Not: Project Wiki Entity; But: Project Wiki Entity Content)
- URLs and Menu locations should simply match up starting with
/admin/
What do you think?
- Status changed to Needs work
over 1 year ago 9:22am 30 August 2023 - 🇩🇪Germany lrwebks Porta Westfalica
I will change this now to the naming system that I have proposed above.
- Status changed to Needs review
over 1 year ago 10:40am 30 August 2023 - 🇩🇪Germany lrwebks Porta Westfalica
Done with the refactoring! If this system does not fit our current setup, please let me know in the review!
- @lrwebks opened merge request.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks for the cleanup and pointing out these @LRWebks! :)
LGTM in large parts already. I'll assign this to me for further review.
I'm not sure about some technical details yet, of which I think Drupal will auto-generate them and I'm not totally sure about the URL and menu positions. We need to discuss that in the team! Background: "Content" would be the right parent menu item for nearly every custom entity, but the Wiki is not a "Project / Website content". It's something dedicated to the admin area and help. So I'd tend to place it all in admin/help/ ... for the list and creation of wiki entities. - Assigned to Anybody
- Status changed to Needs work
over 1 year ago 8:20am 31 August 2023 - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
about 1 year ago Waiting for branch to pass - Status changed to Needs review
about 1 year ago 8:13am 7 September 2023 - Assigned to lrwebks
- Status changed to Needs work
2 months ago 2:19pm 30 September 2024 - 🇩🇪Germany lrwebks Porta Westfalica
Now that much has changed with the module and the routing, I think it is best if we postpone this until the very end, where we can take a final look at the routing in here. If this is needed sooner, we could always move this up in the list again.