Drupal.t() does not respect locale_custom_strings

Updated the IS.

Something like this should fix the issue (based on D7 patch). But tests are still needed I think (so keeping at NW).

Added a test for checking the custom string in the generated JS file. Uploading also test-only patch, which should hopefully fail.

The last submitted patch, 4: 3383888-4_test-only.patch, failed testing. View results →

Thanks for including a test-only patch to show this is an issue!

Looking at the actual fix I don't see anything standing out that could be a problem.

Issue summary appears complete

Going to mark this.

The last submitted patch, 4: 3383888-4_test-only.patch, failed testing. View results →

The last submitted patch, 4: 3383888-4_test-only.patch, failed testing. View results →

The last submitted patch, 4: 3383888-4_test-only.patch, failed testing. View results →

The last submitted patch, 4: 3383888-4_test-only.patch, failed testing. View results →

The last submitted patch, 4: 3383888-4_test-only.patch, failed testing. View results →

The last submitted patch, 4: 3383888-4_test-only.patch, failed testing. View results →

Tested this locally with umami install profile.

Unfortunately the steps to reproduce don't work anymore because of changes to field UI.

But you can still see it with these, so updating the issue summary:

$settings['locale_custom_strings_es'][''] = [
  'Label' => 'LabelCUSTOM',
  'Edit' => 'EditCUSTOM',
  'List additional actions' => 'Additional actions ACTIONS!',
];

Committed and pushed to 11.x
Backported to 10.0.x

Thanks folks

Automatically closed - issue fixed for 2 weeks with no activity.