- Issue created by @murz
- last update
about 1 year ago 30,060 pass - @murz opened merge request.
- last update
about 1 year ago 30,060 pass - Status changed to Needs review
about 1 year ago 8:32pm 13 September 2023 - πΊπΈUnited States xjm
Is this a docs-only change, or do we want to have a followup adding a return typehint in a major release?
We could follow the steps along the lines of using the deprecation process for constructor and interface method signature changes β , although I haven't tested whether it would work for return typehints.
- πΊπΈUnited States smustgrave
@Murz as the author of this ticket could you answer #7
- π¦π²Armenia murz Yerevan, Armenia
Yes, this is a docs-only change to return the extended type hint, that explicitly describes that returning NULL is allowed and in which cases. Because except for the docs, returning NULL is possible in the
EntityRepositoryInterface::getTranslationFromContext()
, but the docs say that this is not allowed.So, with this change, we can move forward with the language fallback logic to return NULL, if no fallback translations are allowed (in separate issues).
- Status changed to RTBC
about 1 year ago 1:47pm 19 September 2023 - πΊπΈUnited States smustgrave
Opened https://www.drupal.org/project/drupal/issues/3388290 π language fallback logic to return NULL Active as the follow up, will need more info.
- last update
about 1 year ago 30,168 pass - πΊπΈUnited States smustgrave
scratch that see we have π EntityRepository::getTranslationFromContext() function forcibly adds default entity language to fallback candidates Needs review
- last update
about 1 year ago 30,168 pass - last update
about 1 year ago 30,205 pass - last update
about 1 year ago 30,208 pass - last update
about 1 year ago 30,358 pass, 2 fail - last update
about 1 year ago 30,360 pass - last update
about 1 year ago 30,360 pass 39:49 13:42 Running- last update
about 1 year ago 30,377 pass - last update
about 1 year ago 30,382 pass - last update
about 1 year ago 30,383 pass, 1 fail - last update
about 1 year ago 30,393 pass - last update
about 1 year ago 30,397 pass 54:48 50:56 Running- last update
about 1 year ago 30,415 pass - last update
about 1 year ago 30,420 pass - last update
about 1 year ago 30,426 pass - last update
about 1 year ago 30,434 pass - last update
about 1 year ago 30,438 pass - last update
about 1 year ago 30,456 pass - last update
about 1 year ago 30,472 pass - last update
about 1 year ago 30,483 pass - last update
about 1 year ago 30,486 pass - last update
about 1 year ago 30,486 pass 39:49 36:42 Running- last update
about 1 year ago 30,511 pass - last update
about 1 year ago 30,519 pass - Status changed to Fixed
about 1 year ago 3:54pm 12 November 2023 - πΊπΈUnited States xjm
Committed to 11.x, 10.2.x, and 10.1.x as a patch-safe API documentation improvement. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.