- Issue created by @Grevil
- Status changed to Needs work
over 1 year ago 12:39pm 28 August 2023 - 🇩🇪Germany lrwebks Porta Westfalica
Finished and open for review!
Also took the time to replace a Drupal call for the current user with dependency injection and write a permissions test accordingly. - Status changed to Needs review
over 1 year ago 9:40am 29 August 2023 - @lrwebks opened merge request.
- Status changed to Needs work
over 1 year ago 9:42am 31 August 2023 - 🇩🇪Germany Anybody Porta Westfalica
Nice work @LRWebks - I left some comments - back to NW.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - Status changed to Needs review
over 1 year ago 10:19am 14 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
@LRWebks: I just replied, you may proceed. Don't forget to test that what you implemented still works. Do we have tests in place for this already?
- Status changed to Needs work
over 1 year ago 11:05am 14 September 2023 - last update
over 1 year ago 1 pass, 2 fail - Status changed to Needs review
over 1 year ago 8:32am 15 September 2023 - 🇩🇪Germany lrwebks Porta Westfalica
I have simplified the permission check according to the comments you have left me, and even though the (other) tests may fail here, the ProjectWikiPermission test is testing the developerContent permission accordingly and is testing OK. Everything should work now! :) Back to review!
- Status changed to Needs work
over 1 year ago 8:45am 15 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
Back to NW, left comments.
Please save us time by first reviewing the changes yourself, before asking others for review. You would have seen the trailing comma and needless new line. Thanks!
- last update
over 1 year ago 1 pass, 2 fail - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - Status changed to Needs review
over 1 year ago 9:48am 15 September 2023 - 🇩🇪Germany lrwebks Porta Westfalica
Should be completely fine now! To review! :)
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 9:55am 15 September 2023 - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - Status changed to Fixed
over 1 year ago 9:59am 15 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.