- Issue created by @megadesk3000
- @megadesk3000 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:29pm 25 August 2023 - Status changed to Needs work
over 1 year ago 4:19pm 25 August 2023 - 🇪🇪Estonia drugan
Hi,
Further development will continue in the 2.0.x branch.
Please, try to fix the following errors and test your changes manually on each of the latest 9.x and 10.x versions:
drugan@test-xattributes-web:/var/www/html$ vendor/bin/phpstan analyze -l 0 web/modules/contrib/commerce_xattributes-3383392/ 13/13 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ ---------------------------------------------------------------------------------------------------- Line modules/commerce_cattributes/commerce_cattributes.module ------ ---------------------------------------------------------------------------------------------------- 45 Inner named functions are not supported by PHPStan. Consider refactoring to an anonymous function, class method, or a top-level-defined function. See issue #165 (https://github.com/phpstan/phpstan/issues/165) for more details. ------ ---------------------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------------------------------- Line modules/commerce_cattributes/src/Plugin/Field/FieldWidget/CorrectProductVariationAttributesWidget.php ------ ------------------------------------------------------------------------------------------------------- 120 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------------------- Line src/Form/XattributesProductVariationTypeForm.php ------ --------------------------------------------------------------------------------------------------- 92 Method Drupal\commerce_xattributes\Form\XattributesProductVariationTypeForm::save() should return int but return statement is missing. ------ --------------------------------------------------------------------------------------------------- [ERROR] Found 3 errors
- Status changed to Fixed
over 1 year ago 4:01pm 13 September 2023 - Status changed to Fixed
over 1 year ago 4:16pm 13 September 2023