Slider item render issue.

Created on 25 August 2023, 10 months ago
Updated 12 October 2023, 9 months ago

Problem/Motivation

Slider item render issue when no value added in slider item in theme settings.

Steps to reproduce

  1. Install the theme and set as default.
  2. Go to the theme settings.
  3. Update select number of slider display count into 4.
  4. Go to the home page
  5. Go to the home page
  6. Go to 4 slide in slider component.

you will find the broken slide issue.

Proposed resolution

Slide should not visible in FE when value not added.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India djsagar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @djsagar
  • 🇮🇳India shubham_jain

    Hi @djsagar,
    I install the theme and followed Steps to reproduce through which I encountered similar problem.

    I went into theme settings and saw that when we create 4th slide you have to enter the data except for the image field (based on previous three sliders) and save the configuration. Went back to the home page but the issue was still there as you suggested.

    Then I looked into the code and found out that there are only three images for three sliders and there was not a fourth image for the fourth slider. So i inserted the fourth image with the name 'slider4_image.jpg'. After that i cleared the cache and went to the fourth slide and the issue was resolved.

    Follow the above process and you will see that the error will be gone. i have attached the screenshot for the reference.
    Please review and verify.

  • 🇮🇳India djsagar

    Hi @shubham_jain,

    We need add validation in the empty slide, if we do not enter any data in slide, The slide count should not be created in FE.

    Thanks!

  • Assigned to Gautam_105@
  • Issue was unassigned.
  • 🇮🇳India Gautam_105@

    Hi, I installed the theme and this issue was reproduced in my local setup. I fixed the issue and have created the patch file for it.
    Please review and verify.

  • Status changed to RTBC 9 months ago
  • 🇮🇳India mukesh-kumar3 Dharmshala

    Hi Gautam_105@ i have applied your patch and working as intended so there is no broken slide issue on the page I have attached the screenshot below of applying patch successfully and also validation work as intended for empty slide so moving this issue to RTBC.

    Steps to Verify

    1. Install the theme and set as default.

    2. Go to the theme settings.

    3. Update select number of slider display count into 4.

    4. Go to the home page

    5. There is no broken slide founded.

    Thanks!

  • 🇮🇳India Gautam_105@

    @soumya soni ,
    i have apply patch #6 and created MR for the same. Please review and merge my MR.

  • @gautam_105 opened merge request.
  • Status changed to Fixed 9 months ago
  • 🇮🇳India soumya soni indore

    Thankyou all for your contribution.

  • Status changed to Fixed 9 months ago
Production build 0.69.0 2024