If case in checksumExists() will never be reached.

Created on 24 August 2023, 10 months ago

Updated 21 September 2023, 9 months ago

Problem/Motivation

Currently, checksumExists() is only ever called inside 'canSave()', while 'canSave()' is only every called inside MediaUniqueChecksumValidator's 'validate()' method. BUT during validation the media entity isn't created, hence the id is ALWAYS NULL, making the mid-check obsolete:

    if ($mid !== NULL) {
      $query->condition('mid', $mid, '!=');
    }

Steps to reproduce

Proposed resolution

Remove the mid check.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Grevil
Comment 10 months ago →
🇩🇪Germany Anybody Porta Westfalica
Assigned to nterbogt
Comment 10 months ago →
🇩🇪Germany Anybody Porta Westfalica
Isn't this also called when recalculating the checksums? I'm wondering if this can be true, perhaps @nterbogt can quickly answer this?

If not, we should check this finally and prepare a MR to remove it indeed.
Comment 10 months ago →
🇩🇪Germany Grevil
Isn't this also called when recalculating the checksums

It isn't.
Comment 9 months ago →
🇩🇪Germany Anybody Porta Westfalica
Any idea @nterbogt? Was it just a mistake?

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024