Merge with MediaContextualCrop

Hi, thanks for reaching out.

Do I understand it correctly, that MediaContextualCrop basically supports the same functionality? The Media Library Media Modify Focal Point had a single use-case: That when using the Media Library Media Modify module, our customers have expected to modify the global cropping for an image rather than creating a contextual cropping wherever the image is reused.

Yes,

The main point of the collection are you can also use ImageWidgetCrop for contextual croping and use contextual crop (focal point / iwc) in media embed

I've been looking at both modules and would say that they are completely different solution. Please correct me if I'm wrong.

@DrDam module "Media Contextual Crop" allows the focal point to be different per field. So if I add a media image that allows for a focal point crop I can change the focal point independently on the field. So I could use the same media image on 2 different pages and have a different focal point for each use. Which then allows me to display an image style for each that would be different.

@szeidler This module "Media Library Media Modify Focal Point" would appear allow you to edit the focal point that is added to the media item but not allow a different focal point crop per instance of the field. So if I edited the media image focal point on node 1 and I had also used the same media item on node 2 the focal point would also be changed on node 2.

@erichomanchuk :

So if I add a media image that allows for a focal point crop I can change the focal point independently on the field

In fact, if you add twice the same media in a media_ref field, you can provide a contextual focal point on each.

@szeidler This module "Media Library Media Modify Focal Point" would appear allow you to edit the focal point that is added to the media item but not allow a different focal point crop per instance of the field. So if I edited the media image focal point on node 1 and I had also used the same media item on node 2 the focal point would also be changed on node 2.

Here, you have discribe the "native behavior" between media & crop.
To be honest, I did'nt have test this module, I have juste check code, and realise, we address the same point.

I aggreed that the technical approach are totaly different. @szeidler have solve the single use-case issue (media reference field & focal point), "Media Contextual Crop" propose a global solution : for media reference field or Ck5 media embed & for focal Point or Image Widget Crop

Here, you have discribe the "native behavior" between media & crop.
To be honest, I did'nt have test this module, I have juste check code, and realise, we address the same point.

You're right: it's the native behavior with Media & Crop. But it is not the native behavior when using the Media Library Media Modify Focal Point module in addition. Then (at the time the module was created) the focal point position was not stored at all. When using the Media Library Media Modify Focal Point module it will store the position as the global media focal point position.

I guess both module solutions (purely contextual or global) have their use-cases.