PHP 8.2: Dynamic Properties are deprecated

Hi,

@heddn, thanks for the patch.

But it seems not ready for PHP 8.2 regarding tests results. Or is not related?

Working on fixes. I found those failures come from 🐛 Improve documentation of hook_theme_suggestions_HOOK_alter() Fixed .

This probably is a little overboard. But it fixes the failing test and a few other test warnings that came from phpunit. Apparently naming an abstract class ending in Test isn't desirable any more.

I'm also getting some JS test failures now, but I don't know if that is because of flaky js testing or not, so we'll see how the testbot likes things.

Hi,

Thanks for the updated patch.

Here is my review.

1. +++ b/src/Definition/PatternDefinition.php
   @@ -408,7 +408,14 @@ class PatternDefinition extends PluginDefinition implements DerivablePluginDefin
   +    $this->definition['theme hook'] =     $altered_hook = str_replace('-', '_', $theme_hook);
   

   Why not having only `$this->definition['theme hook'] = $altered_hook`?

2. +++ b/src/Plugin/Deriver/AbstractPatternsDeriver.php
   @@ -34,10 +34,12 @@ abstract class AbstractPatternsDeriver extends DeriverBase implements PatternsDe
   +  protected string $basePluginId;
   

   Should an inheritdoc be added?

3. +++ b/tests/src/Unit/Element/PatternPreviewTest.php
   @@ -3,15 +3,16 @@
   + * @group legacy
   

   Why this addition?

1) That's an oversight. It shouldn't be there.
2) I don't think there is a parent variable to inherit doc from. If we need to repeat the variable name in a comment, I can do that.
3) I don't remember. If it isn't needed to get passing tests, we can remove it.

Hi,

I have enabled Gitlab CI and fix the problem of templates suggestions in 📌 Enable Gitlab CI + Update README + Coding standards Fixed .

@heddn, Could you please create a MR on the latest codebase. I think with the change from your first patch only.

Tests pass green on php 8.2 in the bot. I couldn't figure out an easy way to run a test-only pass on the code to demonstrate the error w/o any fixes..

Thanks a lot for the quick response time.

No problem. It fixes a PHPStan error so I guess it is ok.

I will just push a PHPCS fix.

Automatically closed - issue fixed for 2 weeks with no activity.