- Issue created by @hchonov
- Status changed to Needs review
over 1 year ago 1:40pm 21 August 2023 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
about 1 year ago 1 pass - 🇩🇪Germany majid.ali
Re-rolling #2 🐛 Multiple contextual filters / arguments are not supported when a value is not provided for them Needs work for updated 8.x-2.x-dev branch.
- Status changed to Needs work
10 months ago 5:29am 19 June 2024 - 🇬🇧United Kingdom scott_euser
Thanks for the work on this! A few things:
- Can this be converted to a merge request to make it easier to review and comment please?
- The last unset($argument) is actually deleting the argument is it not? Since it is passed by reference.
- This needs test coverage, which can be added to ViewsReferenceSettingsTest.php (there is an existing method ::testArgument())
- First commit to issue fork.
- Merge request !61Issue #3382310: Multiple contextual filters / arguments are not supported when... → (Open) created by sleitner
- Status changed to Needs review
10 months ago 10:12pm 25 June 2024 - Status changed to Needs work
10 months ago 5:42am 27 June 2024 - 🇬🇧United Kingdom scott_euser
Great thank you for the progress on this! Just needs the tests adding now as per my comment in #4. Thanks!
- Status changed to Needs review
8 months ago 10:15pm 6 September 2024 - 🇬🇧United Kingdom scott_euser
This looks good for me, thank you for adding the test coverage! I have not actively used arguments in any of my projects, so I am hoping one of the other followers of this issue can confirm they are successfully using this MR patch and RTBC it.
- 🇬🇧United Kingdom scott_euser
If it gets stuck as a result, I'll set a reminder to try to do more thorough manual tests eventually myself but I have a bit of a backlog at the moment.
- 🇩🇪Germany hchonov 🇪🇺🇩🇪🇧🇬
Somehow during the development the usage of the unserialized data broke. I fixed this now with https://git.drupalcode.org/project/viewsreference/-/merge_requests/61/di...
I am also attaching a static patch of the MR.