Incompatible with Clientside Validation and required checkbox

Also I had to add for coloring:

.form-item--error-message {
  color: var(--input--error-border-color);
}

@Grimreaper can you test if this is a bug related only to Gin Login or if it happens also in Gin in general? As then we'd better move this issue there to generally fix it.

Hi @saschaeggi,

I can confirm this happens in Gin in general.

I have tested on a node create form where I added a required boolean field:

Hi,

With Gin 3.0.0-rc13, The checkbox is now accessible ok, but what about adding an error color on the text?

Can you create a MR to add it? Cheers!

Hi,

MR created.

I have manually edited the CSS files and also handling error message outside of checkbox, like text fields.

See attached screenshots.

@Grimreaper I've pushed some code simplification as we can generally make label.error available in form.css (pretty sure there will be more situations).

Please have a look so we can proceed with this 👀

Thank you!

Hi @saschaeggi,

Thanks for the simplification.

It's ok for checkbox, but does not take other form elements into accounts.

@Grimreaper 💯, can you check the latest changes? Thank you!

Thanks @saschaeggi.

Now ok for textfield, but broken (or current behavior without the MR) on checkbox.

As shown on the screenshot, the problem is this selector :not(.form-checkboxes):not(td):not(.tabledrag-cell-content__item):not(.media-library-item__click-to-select-checkbox):not(.field-content):not(.tablesaw-cell-content) > .form-type--checkbox label

gurpreet@materialplus → made their first commit to this issue’s fork.

Hi team
I have created an MR and aligned the validation message for the checkbox.
MR:- https://git.drupalcode.org/project/gin/-/merge_requests/478/diffs?commit...

I have revert it the phpcs fixes on the css files. Css files are automatically created with npm so no need to care for them.
I also removed on unneeded empty line.

Screenshots:
before →
after →

The issue seems to be fixed.

There seems to be a problem with the error position. It should always be below the field I think. I ll open a follow up issue for this.