Wrong comment display for sites configuring base field display in the UI

Issue created by @adamps
Status changed to Needs review over 1 year ago11:40am 18 August 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,047 pass
Comment over 1 year ago →
🇬🇧United Kingdom adamps
Comment over 1 year ago →
🇬🇧United Kingdom adamps
Status changed to Needs work over 1 year ago6:27pm 21 August 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Seems olivero is missing the change too. And didn't see in the parent issue mention if that should be excluded.
Status changed to Needs review over 1 year ago11:34am 22 August 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,056 pass
Comment over 1 year ago →
🇬🇧United Kingdom adamps
Thanks well spotted. Also the comments in both need updating.
Status changed to RTBC over 1 year ago3:10pm 22 August 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Thanks for addressing that so quickly!

Think this is ready for committer review.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,058 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,060 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,048 pass, 2 fail
Comment about 1 year ago →
System Message
The last submitted patch, 5: starterkit-comment-display.3381877-5.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,063 pass
Comment about 1 year ago →
🇬🇧United Kingdom adamps
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,134 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,135 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,136 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,128 pass, 1 fail
Comment about 1 year ago →
System Message
The last submitted patch, 5: starterkit-comment-display.3381877-5.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,161 pass
Comment about 1 year ago →
🇬🇧United Kingdom adamps
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,164 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,168 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,168 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,205 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,363 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,360 pass, 1 fail
Comment about 1 year ago →
System Message
The last submitted patch, 5: starterkit-comment-display.3381877-5.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,360 pass
Comment about 1 year ago →
🇬🇧United Kingdom adamps
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,360 pass
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
Waiting for branch to pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,377 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,382 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,384 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,386 pass, 1 fail
Comment about 1 year ago →
System Message
The last submitted patch, 5: starterkit-comment-display.3381877-5.patch, failed testing. View results →
Comment about 1 year ago →
🇮🇳India viren18febS
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,397 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,410 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,415 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,420 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,426 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,434 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,438 pass

lauriii → committed 54e5f9e7 on 11.x

Issue #3381877 by AdamPS, smustgrave, viren18febS: Wrong comment display...

Comment about 1 year ago →

System Message

lauriii → committed dc84da68 on 10.2.x

Issue #3381877 by AdamPS, smustgrave, viren18febS: Wrong comment display...

Comment about 1 year ago →

System Message

lauriii → committed d73384c9 on 10.1.x

Issue #3381877 by AdamPS, smustgrave, viren18febS: Wrong comment display...

Status changed to Fixed about 1 year ago5:07pm 26 October 2023
Comment about 1 year ago →
🇫🇮Finland lauriii Finland
Committed 54e5f9e and pushed to 11.x. Also cherry-picked to 10.2.x and 10.1.x. Thanks!
Comment about 1 year ago →
🇬🇧United Kingdom adamps
Great thanks
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Wrong comment display for sites configuring base field display in the UI

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities