- Issue created by @Gábor Hojtsy
- Status changed to Needs review
over 1 year ago 10:49am 18 August 2023 - 🇳🇿New Zealand quietone
I compared the markdown table with the original and I did not find any errors.
I added centering to the value cells, so I shouldn't really RTBC this.
- 🇭🇺Hungary Gábor Hojtsy Hungary
I fixed the lettering to be more uniform. Bolded C and A as those are the key governing parts of the table.
Before
After
The main thing lost is the colors, but that is not possible in markdown unfortunately. I tried to be creative with the emoji letters to get that back as much as possible while keeping it editable with PACSI changes comparable directly in the git history.
@quietone: did you commit your centering?
- 🇭🇺Hungary Gábor Hojtsy Hungary
Added the centering, and it looks way better indeed :) Now you can review ;)
- Status changed to RTBC
over 1 year ago 12:48pm 18 August 2023 - 🇳🇿New Zealand quietone
Yes, I committed it but did not push the change.
I checked the new commits since #2. They are all correct. The only thing wrong was me missing the spelling and capitalization error.
Happy to set this RTBC.
- 🇺🇸United States xjm
For some reason I can't open an MR for this and no existing MR is shown?
- @xjm opened merge request.
- 🇺🇸United States xjm
I was able to open the MR from GitLab; not sure why the d.o buttons were missing.
- 🇺🇸United States xjm
It just occurred to me that the image would also be wrong regardless once the Project Lead changes went in, so we should commit this and add my points to the scope of the other issue.
-
Gábor Hojtsy →
committed 8006ff9d on main authored by
xjm →
Issue #3381857 by Gábor Hojtsy, quietone: Convert Drupal core PACSI...
-
Gábor Hojtsy →
committed 8006ff9d on main authored by
xjm →
- Status changed to Fixed
over 1 year ago 6:20pm 19 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.