- Issue created by @ebremner
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
- Status changed to Postponed: needs info
over 1 year ago 4:45pm 14 August 2023 - 🇮🇳India vishal.kadam Mumbai
The project has multiple branches. Which branch should be reviewed?
- Status changed to Needs review
over 1 year ago 6:45pm 14 August 2023 - Status changed to Needs work
over 1 year ago 7:29am 16 August 2023 - 🇮🇳India vishal.kadam Mumbai
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml layout_builder_ids/ FILE: layout_builder_ids/src/EventSubscriber/LayoutBuilderIdsConfigureSection.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: layout_builder_ids/src/EventSubscriber/LayoutBuilderIdsConfigureBlock.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------
2. Replace README.txt with README.md file.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
- Status changed to Needs review
over 1 year ago 3:01pm 16 August 2023 - 🇮🇳India vishal.kadam Mumbai
Rest looks fine to me.
Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
- Dries → ' post on Responsible maintainers
- Best practices for creating and maintaining projects →
- Maintaining a drupal.org project with Git →
- Commit messages - providing history and credit →
- Release naming conventions → .
- Helping maintainers in the issue queues →
You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.I thank all the reviewers.
- Assigned to apaderno
- Status changed to Fixed
about 1 year ago 11:22am 27 September 2023 - 🇨🇦Canada ebremner
Why does the project still show as not covered by security?
- 🇮🇳India vishal.kadam Mumbai
You need to edit the project page and update coverage option.
Automatically closed - issue fixed for 2 weeks with no activity.