- Issue created by @khiminrm
- Status changed to Needs review
over 1 year ago 1:56pm 14 August 2023 - last update
over 1 year ago 16 pass - πΊπ¦Ukraine khiminrm
I'm not sure about cache context. Maybe we need some specific new cache context or tags. For example when the rates are changed, not sure if the display will be updated.
- last update
over 1 year ago 16 pass - @valic opened merge request.
- Status changed to Active
about 1 year ago 11:15am 9 October 2023 - ππ·Croatia valic Osijek
Opened an MR, and removed injected service `commerce_currency_resolver.currency_helper`, we should not inject it. Because we don't want an additional dependency on the commerce_exchanger module. It is reverse, resolver has a dependency on the exchanger module.
Additionally moved this issue to go against 2.0.x branch, we are not adding ti 8.x anything
- Status changed to Fixed
about 1 year ago 11:30am 9 October 2023 - ππ·Croatia valic Osijek
Tnx.
Added. About cache contexts, this can be follow up, I people use it on frontend, we would need inject some additional context / tags.
But we can do that in follow up
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
6 months ago 1:19pm 21 June 2024 - π³π¬Nigeria chike Nigeria
Please how does this issue relate to this one I raised here, https://www.drupal.org/project/commerce_exchanger/issues/3449136 π¬ Converted price not showing on product page until product is added to cart Active
Thank you.
- π³π¬Nigeria chike Nigeria
Using the 'Calculated' formatter solved the issue I was talking about in #12.
Thank you and apologies for the trouble.