Allow to use ' as enclosure for using in href attributes

The last submitted patch, 2: 3380978-2.patch, failed testing. View results →

@facine I think adding this feature is great. As it is currently written, though, it looks like there's nothing that forces the content to use the same type of quote character; a double quote could be first and a single quote second.

@facine can you also provide an example of how this affects you? The token replacement will also replace the double quotes, so it's unclear to me how this is an actual issue.

@pianomansam, I am attaching a new patch applying the suggested changes.

An example would be:

<a href="mailto:[current-user:mail|'email@example.com']">

@facine, thanks for the updated patch. I'll review it.

Also, thanks for the scenario where this could be an issue. Is this particular one breaking something for you? Whether you use <a href="mailto:[current-user:mail|'email@example.com']"> or <a href="mailto:[current-user:mail|"email@example.com"]">, the result will be the same:

<a href="mailto:email@example.com">

I have issues with: <a href="mailto:[current-user:mail|"email@example.com"]">, this is the result: <a href="mailto:[current-user:mail|" email=""> because the double quote is closing the href attribute.

@facine Hmm, can you provide a bit more context? Is a text format involved? Any particular modules or contexts where this is happening?

@pianomansam, using a full html text format and the token filter module.

I was wondering if it was the token filter module. What's the order of filters? If the token filter first?