Contrib.social

Webform variants don't respect Computed Twig

Open on Drupal.org →
Created on 11 August 2023, about 2 years ago

Problem/Motivation

If you create a Computed Twig field, and change the Twig template in a variant, the value will be recorded correctly in the db, but the results of the original Twig template will be passed to the webform handlers.

Steps to reproduce

* Create a webform with a Computed Twig field.
* Create a variant, and change the template for the Computed Twig field.

Proposed resolution

We need to apply the variants when getting the data during validation.

🐛 Bug report
Status

Needs review

Version

6.1

Component

Code

Created by

🇺🇸United States MegaphoneJon

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @MegaphoneJon
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 2 years ago
    Patch Failed to Apply
  • Comment about 2 years ago →
    🇺🇸United States MegaphoneJon
  • First commit to issue fork.
  • Merge request !353Update WebformSubmission.php → (Open) created by djsagar
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 2 years ago
    537 pass
  • Comment about 2 years ago →
    🇮🇳India djsagar

    Created MR, kindly review.

  • Comment over 1 year ago →
    🇺🇸United States jrockowitz Brooklyn, NY
  • Pipeline finished with Success
    over 1 year ago
    Total: 2158s
    #140262
  • Pipeline finished with Failed
    11 months ago
    Total: 587s
    #313545
  • Pipeline finished with Skipped
    11 months ago
    #315783
  • Pipeline finished with Success
    11 months ago
    Total: 768s
    #316928
  • Pipeline finished with Canceled
    11 months ago
    Total: 421s
    #320288
  • Pipeline finished with Skipped
    11 months ago
    #320309
  • Pipeline finished with Canceled
    11 months ago
    Total: 1262s
    #320295
  • Pipeline finished with Success
    9 months ago
    Total: 169s
    #378930
  • Pipeline finished with Failed
    9 months ago
    Total: 329s
    #382126
  • Pipeline finished with Canceled
    9 months ago
    Total: 109s
    #382130
  • Pipeline finished with Failed
    9 months ago
    Total: 282s
    #382131
  • Pipeline finished with Failed
    9 months ago
    Total: 668s
    #382707
  • Pipeline finished with Canceled
    9 months ago
    Total: 208s
    #382712
  • Pipeline finished with Canceled
    9 months ago
    Total: 63s
    #382713
  • Pipeline finished with Failed
    9 months ago
    Total: 328s
    #382714
  • Pipeline finished with Canceled
    9 months ago
    Total: 1155s
    #382716
  • Pipeline finished with Success
    9 months ago
    Total: 909s
    #382725
  • Comment 12 days ago →
    🇺🇸United States jrockowitz Brooklyn, NY

    jrockowitz → changed the visibility of the branch 3380755-webform-variants-dont to hidden.

  • Comment 12 days ago →
    🇺🇸United States jrockowitz Brooklyn, NY

    Let's see if tests pass via 6.3.x

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024