- Issue created by @rishabjasrotia
- @rishabjasrotia opened merge request.
- Status changed to Needs review
over 1 year ago 9:00am 11 August 2023 - Issue was unassigned.
- ๐ฎ๐ณIndia dineshkumarbollu
Hi
Removing code results functionality changesgetImplementations()
now is replacing withinvokeAllWith()
can you check once. Hello @dineshkumarbollu,
The invokeAllWith() method is already defined in HookEventDispatcherModuleHandlerProxyTrait.php
The old Drupal 9 method was defined which causes the fata error. Removal of Deprecated code is the possible solution.- Status changed to Needs work
over 1 year ago 11:30am 11 August 2023 - ๐ฎ๐ฉIndonesia el7cosmos ๐ฎ๐ฉ GMT+7
Thanks @rishab, there is one PHPCS error (https://git.drupalcode.org/project/hook_event_dispatcher/-/pipelines/157...), can you fix that?
- ๐ฎ๐ณIndia akshay.singh Noida
akshay.singh โ made their first commit to this issueโs fork.
- Status changed to Needs review
over 1 year ago 11:39am 11 August 2023 - Status changed to Needs work
over 1 year ago 2:39pm 14 August 2023 - ๐ฎ๐ฉIndonesia el7cosmos ๐ฎ๐ฉ GMT+7
According to https://www.drupal.org/node/3000490 โ , we should also remove
implementsHook()
method. - Status changed to Needs review
over 1 year ago 2:49pm 14 August 2023 -
el7cosmos โ
committed 70dde19c on 4.x authored by
rishabjasrotia โ
Issue #3380632 by rishabjasrotia, akshay.singh, el7cosmos: Call to...
-
el7cosmos โ
committed 70dde19c on 4.x authored by
rishabjasrotia โ
- Status changed to Fixed
over 1 year ago 3:01pm 14 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 12:02pm 30 August 2023 - ๐ฉ๐ชGermany broon Potsdam
I am not sure if I am missing something, but when using the patch from #16 or using the current dev version, I'll got the following error:
Fatal error: Class Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Drupal\Core\Extension\ModuleHandlerInterface::getImplementations, Drupal\Core\Extension\ModuleHandlerInterface::implementsHook) in web/modules/contrib/hook_event_dispatcher/src/HookEventDispatcherModuleHandler.php on line 15
- ๐ฉ๐ชGermany broon Potsdam
Scrap that, working as designed. Due to an unmet dependency, my dev system was not updated to 10.0.10 as intended but rather to 10.0.0-alpha4.