- Issue created by @ckrina
- First commit to issue fork.
- @hooroomoo opened merge request.
- Assigned to hooroomoo
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:38pm 15 August 2023 - Status changed to Needs work
over 1 year ago 12:47pm 16 August 2023 - 🇫🇮Finland lauriii Finland
This breaks the logic for the second level menu links. Before this, if a second level menu item was active, the parent would collapse, making the active menu item visible. After this issue, the parent remains collapsed and therefore the active menu item is not visible.
-
ckrina →
committed 8428b181 on 1.x authored by
hooroomoo →
Issue #3380526: Add active state when the sidebar is collapsed
-
ckrina →
committed 8428b181 on 1.x authored by
hooroomoo →
- 🇪🇸Spain ckrina Barcelona
Sorry I merged this without seen @lauriii's comment. @hooroomoo you will have to keep working from 1.x, sorry.
- Assigned to hooroomoo
- @hooroomoo opened merge request.
- Status changed to Needs review
over 1 year ago 3:09pm 16 August 2023 - 🇺🇸United States hooroomoo
3380526-expand-menu MR is ready for review to fix the menu being expanded on refresh and also add that same behavior when the sidebar is collapsed too on hover.
- Issue was unassigned.
- 🇨🇦Canada claireristow
That's looking great @hooroomoo! I'm noticing the sticky menu's shadow is not working anymore - that's added by the checkOverflow() function. After a quick code review I can't immediately see why it's not running... maybe we just need to add that function call to your new expandActiveMenu() function?
- Status changed to Needs work
over 1 year ago 3:46pm 16 August 2023 - Status changed to Needs review
over 1 year ago 4:22pm 16 August 2023 - Status changed to RTBC
over 1 year ago 5:53pm 16 August 2023 - 🇨🇦Canada claireristow
Thanks @hooroomoo, I'd say that's good to merge!
- Status changed to Fixed
over 1 year ago 11:11am 17 August 2023 -
ckrina →
committed c5e52f4f on 1.x authored by
hooroomoo →
Issue #3380526: Add active state when the sidebar is collapsed
-
ckrina →
committed c5e52f4f on 1.x authored by
hooroomoo →
Automatically closed - issue fixed for 2 weeks with no activity.