Rendering is not changing the current content and string translation language

The last submitted patch, 2: 3380219-1-v1.x.patch, failed testing. View results →

Thanks for reporting this problem and already providing a patch!

First off, it’s important to note that, in general, no UI text should be present in the indexed HTML contents of an item, since that would lead to useless results. E.g., if your rendered item all contained a “Tags:” field label, then you couldn’t search for the word “tag” anymore without receiving every single piece of content as a result.
However, some setups of course use rendered fields in the index just as a storage, sort of a cache, to be able to display results faster, without loading the entity. In this case, of course, you want the HTML exactly as it appears on the page, including all UI text. And then I guess you will run into this problem.

Regarding your patch: I’m always very hesitant to change the global application state during indexing, as it seems almost certain that this will lead to problems in some scenarios. However, as we can see by the code that is already in RenderedItem::addFieldValues(), this cannot really be avoided without sacrificing reliability of the generated field values. So, I guess we might need to change the translation language, too, as you indicate – and just hope it doesn’t lead to more problems than it solves.

However, this patch is definitely missing two things:

1. Code that switches the language back after indexing (unless I’m mistaken?)
2. A regression test demonstrating the problem and that it is actually fixed by this change

Would be great if you could add these two things. In any case, thanks again!

Hmm, is this related/the same as 🐛 Rendered HTML Output doesnt respect activeLanguage completely Needs work

@swentel: You’re right, thanks for noticing!

@hchonov: Please see whether the patch in #3035977-43: Rendered HTML Output doesnt respect activeLanguage completely → resolves the problem for you, too. Otherwise, please re-post your patch there.