- Issue created by @mbaycura
- Status changed to Needs review
over 1 year ago 1:31pm 9 August 2023 - Open on Drupal.org →Core: 10.1.0-alpha1 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇮🇳India ravi kant Jaipur
@mbaycura
The condition was not added due to assumption that logo and navigation will be always displaying.
Now i have created patch. - Status changed to RTBC
over 1 year ago 8:25am 10 August 2023 - 🇮🇳India swatidhurandhar
Hi,
Tested the patch from #2 in Drupal 10.1.x. It is working as expected.
Thanks - Status changed to Active
over 1 year ago 7:18pm 10 August 2023 I verified application of the patch from #2 as well and it works. I was not able to use composer as described here → to apply the patch, but was able to manually apply it via git after editing the file paths in the patch to fit my git environment.
Thank for the quick fix- 🇮🇳India swatidhurandhar
@mbaycura I applied the patch through composer and it works fine. You don't need to change any path there, you have to add patch in composer.json as described below and it should work fine.
"patches": {
"drupal/bootstrap_barrio": {
"issue fix": " https://www.drupal.org/files/issues/2023-08-09/3380104-2.patch → "
}
} - Status changed to Needs review
over 1 year ago 7:34am 11 August 2023 - 🇮🇳India ravi kant Jaipur
Thank you @swatidhurandhar,
@mbaycura
I have reconfirmed by applying patch from composer.json and it is applying."patches": { "drupal/bootstrap_barrio": { "Some empty regions are still visible": "https://www.drupal.org/files/issues/2023-08-09/3380104-2.patch" } }
Sometime i also face issue of patch apply so may be mistake during writing apply patch code in your composer.json
and this patch is for base theme. @swatidhurandhar, I didn't change the path in my composer.json, i had to change the paths in the patch file itself in order to use a raw git command, "git apply" to apply the patch manually outside of Drupal and composer.
I double checked my patch syntax and path in my composer.json, but still get this failure notification:
I originally had a different descriptor name, but have always been using the same patch path as the others who have been successful. I tried again using the exact syntax as Ravi, but still have the same problem. Perhaps I'm putting my patch entries in the wrong place.
Here is my composer contents, I put the patch in the "extra":{} section per this documentation → .
I've not applied patches before so there may be something else altogether in my project that is preventing this, but I don't know what that might be.{ "name": "drupal/recommended-project", "description": "Project template for Drupal projects with a relocated document root", "type": "project", "license": "GPL-2.0-or-later", "homepage": "https://www.drupal.org/project/drupal", "support": { "docs": "https://www.drupal.org/docs/user_guide/en/index.html", "chat": "https://www.drupal.org/node/314178" }, "repositories": [ { "type": "composer", "url": "https://packages.drupal.org/8" } ], "require": { "composer/installers": "^2.0", "cweagans/composer-patches": "~1.0", "drupal/bootstrap_barrio": "^5.5", "drupal/bootstrap_sass": "^5.0", "drupal/core-composer-scaffold": "^10.0", "drupal/core-project-message": "^10.0", "drupal/core-recommended": "^10.0", "drupal/devel": "^5.0", "drupal/gin": "^3.0@RC", "drupal/pathauto": "^1.11", "drupal/thex": "^9.2", "drupal/zuvi": "^10.1", "drush/drush": "^11.3" }, "conflict": { "drupal/drupal": "*" }, "minimum-stability": "beta", "prefer-stable": true, "config": { "allow-plugins": { "composer/installers": true, "drupal/core-composer-scaffold": true, "drupal/core-project-message": true, "phpstan/extension-installer": true, "dealerdirect/phpcodesniffer-composer-installer": true, "cweagans/composer-patches": true }, "sort-packages": true }, "extra": { "drupal-scaffold": { "locations": { "web-root": "web/" } }, "installer-paths": { "web/core": [ "type:drupal-core" ], "web/libraries/{$name}": [ "type:drupal-library" ], "web/modules/contrib/{$name}": [ "type:drupal-module" ], "web/profiles/contrib/{$name}": [ "type:drupal-profile" ], "web/themes/contrib/{$name}": [ "type:drupal-theme" ], "drush/Commands/contrib/{$name}": [ "type:drupal-drush" ], "web/modules/custom/{$name}": [ "type:drupal-custom-module" ], "web/profiles/custom/{$name}": [ "type:drupal-custom-profile" ], "web/themes/custom/{$name}": [ "type:drupal-custom-theme" ] }, "patches": { "drupal/bootstrap_barrio": { "Some empty regions are still visible": "https://www.drupal.org/files/issues/2023-08-09/3380104-2.patch" } }, "drupal-core-project-message": { "include-keys": [ "homepage", "support" ], "post-create-project-cmd-message": [ "<bg=blue;fg=white> </>", "<bg=blue;fg=white> Congratulations, you’ve installed the Drupal codebase </>", "<bg=blue;fg=white> from the drupal/recommended-project template! </>", "<bg=blue;fg=white> </>", "", "<bg=yellow;fg=black>Next steps</>:", " * Install the site: https://www.drupal.org/docs/installing-drupal", " * Read the user guide: https://www.drupal.org/docs/user_guide/en/index.html", " * Get support: https://www.drupal.org/support", " * Get involved with the Drupal community:", " https://www.drupal.org/getting-involved", " * Remove the plugin that prints this message:", " composer remove drupal/core-project-message" ] } }, "require-dev": { "kint-php/kint": "^5.0" } }
-
hatuhay →
committed eb8904e5 on 5.5.x authored by
ravi kant →
Issue #3380104 by ravi kant: Some empty regions are still visible
-
hatuhay →
committed eb8904e5 on 5.5.x authored by
ravi kant →
- Status changed to Fixed
over 1 year ago 12:00am 14 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.