Contrib.social

Add comments on why WaitTerminateTestTrait is used

Open on Drupal.org →
Created on 8 August 2023, over 1 year ago
Updated 16 August 2023, over 1 year ago

Problem/Motivation

In ✨ Add a way to delay executions in test runner until terminate event completed in the child site Fixed we introduced the Drupal\Tests\WaitTerminateTestTrait, which made waiting on a lock in the existing test http client middleware possible.
This made it possible to remove the sleep(1) introduced in 🐛 Post-response task running (destructable services) are actually blocking; add test coverage and warn for common misconfiguration Fixed .
However, we also removed the comments on why those sleeps/locks are needed.

Since it's certainly not trivial reading the code why we are waiting, and a future refactor might negate the wait, let's re-introduce these comments.

Steps to reproduce

Proposed resolution

- Look at the comments removed in ✨ Add a way to delay executions in test runner until terminate event completed in the child site Fixed (here's the commit: https://git.drupalcode.org/project/drupal/-/commit/1debb39) and reintroduce them in this issue.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

11.0 🔥

Component
PHPUnit  →

Last updated about 13 hours ago

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024