[1.0.x] CKEditor5 Template

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
Reviewer's task is describing what needs to be changed, not providing patches to fix what reported in a review.

Remember to change status, since Active means the project is not yet ready for review. Needs review is the status used when the project is ready for review.

Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ckeditor5_template/

FILE: ckeditor5_template/ckeditor5_template.libraries.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ckeditor5_template/ckeditor5_template.ckeditor5.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 13 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ckeditor5_template/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 7 WARNINGS AFFECTING 8 LINES
------------------------------------------------------------------------
  3 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
  5 | WARNING | [ ] Line exceeds 80 characters; contains 221 characters
 18 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters
 25 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
 31 | WARNING | [ ] Line exceeds 80 characters; contains 240 characters
 33 | WARNING | [ ] Line exceeds 80 characters; contains 123 characters
 45 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
 49 | ERROR   | [x] Expected 1 newline at end of file; 3 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------


FILE: ckeditor5_template/src/Plugin/CKEditor5Plugin/Template.php
----------------------------------------------------------------------
FOUND 13 ERRORS AND 3 WARNINGS AFFECTING 15 LINES
----------------------------------------------------------------------
  9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\ckeditor5\Plugin\CKEditor5PluginConfigurableInterface.
 10 | WARNING | [x] Unused use statement
 12 | ERROR   | [x] There must be one blank line after the last USE statement; 2 found;
 15 | ERROR   | [x] Missing class doc comment
 18 | ERROR   | [x] Whitespace found at end of line
 20 | ERROR   | [x] Expected 3 space(s) before asterisk; 1 found
 21 | ERROR   | [x] Expected 3 space(s) before asterisk; 1 found
 22 | ERROR   | [x] Expected 3 space(s) before asterisk; 1 found
 23 | ERROR   | [x] Expected 3 space(s) before asterisk; 1 found
 31 | WARNING | [ ] #description values usually have to run through t() for translation
 36 | ERROR   | [x] Expected 1 blank line after function; 2 found
 46 | ERROR   | [x] Expected 1 blank line after function; 2 found
 54 | ERROR   | [x] Expected 1 blank line after function; 2 found
 70 | WARNING | [x] A comma should follow the last multiline array item. Found: '/modules/contrib/ckeditor5_template/template/ckeditor5_template.json.example'
 73 | ERROR   | [x] Expected 1 newline at end of file; 0 found
 73 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ckeditor5_template/css/layout.css
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 2 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 3 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 4 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ckeditor5_template/css/admin.css
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | ERROR | [x] Additional whitespace found at start of file
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

We have fixed all phpcs issues.

Rest looks fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

No issues found
Changing status to RTBC!

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

Thank you!

Automatically closed - issue fixed for 2 weeks with no activity.