Convert enable/disable to install/uninstall in hook_help()

The error was a typo.

The last submitted patch, 4: 3379495-4.patch, failed testing. View results →

Applying patch #6 and running the search from the issue summary I get

1 core/modules/automated_cron/automated_cron.module
2 core/modules/big_pipe/big_pipe.module
3 core/modules/block/block.module
4 core/modules/block_content/block_content.module
5 core/modules/book/book.module
6 core/modules/ckeditor5/ckeditor5.module
7 core/modules/comment/comment.module
8 core/modules/config_translation/config_translation.module
9 core/modules/contact/contact.module
10 core/modules/content_moderation/content_moderation.module
11 core/modules/content_translation/content_translation.module
12 core/modules/editor/editor.module
13 core/modules/field/field.module
14 core/modules/field_ui/field_ui.module
15 core/modules/file/file.module
16 core/modules/filter/filter.module
17 core/modules/forum/forum.module
18 core/modules/help/help.module
19 core/modules/image/image.module
20 core/modules/inline_form_errors/inline_form_errors.module
21 core/modules/jsonapi/jsonapi.module
22 core/modules/language/language.module
23 core/modules/layout_builder/layout_builder.module
24 core/modules/link/link.module
25 core/modules/locale/locale.module
26 core/modules/media/media.module
27 core/modules/media_library/media_library.module
28 core/modules/menu_link_content/menu_link_content.module
29 core/modules/menu_ui/menu_ui.module
30 core/modules/node/node.module
31 core/modules/options/options.module
32 core/modules/path/path.module
33 core/modules/rest/rest.module
34 core/modules/search/search.module
35 core/modules/settings_tray/settings_tray.module
36 core/modules/shortcut/shortcut.module
37 core/modules/statistics/statistics.module
38 core/modules/system/system.module
39 core/modules/taxonomy/taxonomy.module
40 core/modules/text/text.module
41 core/modules/toolbar/toolbar.module
42 core/modules/tour/tour.module
43 core/modules/update/update.module
44 core/modules/user/user.module
45 core/modules/views/views.module
46 core/modules/views_ui/views_ui.module

@smustgrave, The grep command finds instances of the strings 'enabl' and 'disabl', both of which will have legitimate uses in help text that are not related to installing or uninstalling a module or theme. As the results show those strings appear in a lot of help files. And those should only be about enabling or disabling functionality, not a module or theme. I think the only way to check is to read all the help file listed in the output.

Setting back to NR

That was my mistake. I went back and checked a few then and wherever I saw disabled/enabled it was along the lines of

4 core/modules/block_content/block_content.module = line 54 could be updated I think

Ah, nice find. Yes, that needs to be changed but it is also out of scope. This issue is only for hook_help text. We'll need another child issue of the parent for comments, which is probably best done after all the siblings of this one.

To ensure that is remembered I added an item to the Remaining tasks in the parent about comments and added a link to the previous comment.

Setting back to NR

In that case think this is good.

The patch no longer applied due to a conflict in help.module. I also converted this to an MR.

Reroll seems good.

In the future, please hide patches when adding an MR to replace them.

There are two very slight errors in the MR where more is being changed than just the words "enable" or "disable", in ways that slightly reduce the grammatical quality of the UI strings. I added suggestions to restore both to the correct stuff. Feel free to accept the suggestions and set the issue straight back to RTBC. Thanks!

🤔 Somehow the rebase was successful but the plain diff still does not apply to 11.x:

error: patch failed: core/modules/help/help.module:36
error: core/modules/help/help.module: patch does not apply
error: patch failed: core/modules/media/tests/src/FunctionalJavascript/MediaReferenceFieldHelpTest.php:41
error: core/modules/media/tests/src/FunctionalJavascript/MediaReferenceFieldHelpTest.php: patch does not apply

I always get confused as to whether the GitLab UI rebase button rebases against core's version of the targeted branch or the MR fork's version of the targeted branch. Going to try to rebase locally.

It worked to apply the diff a few minutes later -- maybe caching or something.

There are dozens of remaining results matched for the find command in the IS, but so far after opening the first several they're all using the word in other contexts (either in code comments rather than t() for the help text, or referring to disabling something other than the module). Going to try my own version with a grep chain.

Generated my own list of remaining strings with the change set applied:
grep -ri "enabl" * | grep "\bt(" | grep -F .module: | grep -v "tests" | grep -v "node_modules" | grep -v "vendor"

I found the following missed changes where help strings refer to enabling a module:

core/modules/language/language.module:        $additional_overview = t("If the Interface Translation module is enabled, this page will provide an overview of how much of the site's interface has been translated for each configured language.");
core/modules/language/language.module:        $additional_continue = t('Depending on your site features, additional modules that you might want to enable are:') . '<ul>';

There is also a related problematic string in

core/modules/system/system.install<code>:
<code>
            'description' => t('The current database driver is provided by the module: %module. The module is currently not enabled. You should immediately <a href=":enable">enable</a> the module.', ['%module' => $provider, ':enable' => Url::fromRoute('system.modules_list')->toString()]),

...which I guess should get a followup.

Checking for "disabl" with the same grep next.

Yes, as the IS said my grep found files to check not the instances. It certainly was not ideal. Glad you created a better one.

Applied the suggestion from the MR and removed 'arrakis'. That can be dealt with at a later time.

Since I am not able to research the scope of the followups I have instead, commented on the meta issue. I referenced the comment above in a comment and the Issue Summary so they will not be forgotten and scope considered. I am removing the tag.

I think #23 is a comment on the rong issue?

I checked the meta and see this was added to the issue summary

To be scoped
More instances to change were found in #3379495-21: Convert enable/disable to install/uninstall in hook_help(). 2 in language_tour_tips_alter and one in system.install.

tour is going away so not sure how much a priority fixing the tour tips are.

Tour is going away from core but moving into contrib, and we want it to move back into core eventually (unlike most deprecated core modules). So I'd still file that followup. Thanks!

Well, okay, I just checked the meta's IS and the two things from #21 are included (including the Tour tips). So that's fine for now.

Saving issue credits.

Reviewed locally with git diff --color-words to validate that each change is replacing the respective instances with the correct word and word form for the case.

Committed to 11.x and 10.2.x as a minor-only set of UI string changes. Thanks!

xjm → closed merge request !4996

Re #23. Ah, this is where my missing comment went. The comment I mean to leave here must be in another issue. That comment explained that I added the items found in #21 to parent meta, not as new issues but items to be scoped properly.

Automatically closed - issue fixed for 2 weeks with no activity.