- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:35am 5 August 2023 - ๐ฎ๐ณIndia Jaspreet-Kaur
Applied patch #2 it seems to fixed the all erors.
- ๐ฎ๐ณIndia dev16.addweb
silvi.addweb โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia dev16.addweb
Added patch(#2) changes and also resolve below mentioned phpcs issues in MR !1, please review.
FILE: /commerce_shipping_mondial_relay-3379421/src/Plugin/Commerce/CheckoutPane/MondialRelay.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------ 117 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter 132 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /commerce_shipping_mondial_relay-3379421/src/Plugin/Commerce/ShippingMethod/MondialRelay.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------- 51 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 32 52 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 32 55 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------
- Status changed to Needs work
7 months ago 1:40pm 23 June 2024 - ๐ต๐ญPhilippines clarkssquared
Hi
I applied patch #2 and confirmed that there's no PHPCS issue a I execute the PHPCS command:
โ commerce_shipping_mondial_relay git:(1.0.x) curl https://www.drupal.org/files/issues/2023-08-05/3379421-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1632 100 1632 0 0 5136 0 --:--:-- --:--:-- --:--:-- 5247 patching file 'src/Plugin/Commerce/ShippingMethod/MondialRelay.php' โ commerce_shipping_mondial_relay git:(1.0.x) โ .. โ contrib git:(main) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml commerce_shipping_mondial_relay/ โ contrib git:(main) โ
However, can you kindly add your changes into the existing MR rather than creating a patch? in that way the maintainer can easily merge and look at it, U will transition this to needs work for that matter.
- Status changed to Fixed
6 months ago 2:01pm 23 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.