- Issue created by @JesperN
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
Thanks, indeed! So let's call this a bug.
- 🇩🇪Germany Grevil
Thanks, @JesperN! We have a lot of custom logic to suggest the library via the Drupal Status Report, hence the composer.json suggest entry probably went under...
Thanks for testing the alpha! 🙂👍
- last update
over 1 year ago 15 pass - @grevil opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:23am 3 August 2023 - Status changed to Needs work
over 1 year ago 7:24am 3 August 2023 - last update
over 1 year ago 15 pass - Status changed to Needs review
over 1 year ago 7:41am 3 August 2023 - 🇩🇪Germany Grevil
All done, please review once again! There is currently no tagged release for the dynamic caption plugin, hence I removed the "dist" entry for that package (see https://github.com/dimsemenov/photoswipe-dynamic-caption-plugin/issues/21).
- last update
over 1 year ago 15 pass - 🇩🇪Germany Grevil
Ok, I found the zip on NPM. Added the zip link accordingly.
- last update
over 1 year ago 15 pass - Status changed to Needs work
over 1 year ago 8:35am 3 August 2023 - last update
over 1 year ago 15 pass - Status changed to Needs review
over 1 year ago 8:39am 3 August 2023 - Status changed to RTBC
over 1 year ago 8:43am 3 August 2023 - 🇩🇪Germany Anybody Porta Westfalica
LGTM. Looking at the code in general I'm wondering why we have to add the sources, while it's already on asset-packagist. Our code will override that. But we shouldn't tackle this now...
Still I think it might be wrong. Perhaps create a follow-up to remove the definition entirely, after looking at the issue and discussion where it was added?
- last update
over 1 year ago 15 pass - last update
over 1 year ago 15 pass - Status changed to Fixed
over 1 year ago 8:43am 3 August 2023 - 🇳🇱Netherlands JesperN
Thanks for the quick response and resolving, looks all good to me now!
Automatically closed - issue fixed for 2 weeks with no activity.