Replacement applies to URLs and breaks links

Open on Drupal.org →

Created on 1 August 2023, about 1 year ago

Updated 10 June 2024, 4 months ago

Problem/Motivation

I tried using this module but it broke links and text rendering when the glossary term appeared in link URLs. I presume there would be similar issues with any html attributes or values within tags.

Steps to reproduce

Paste <a href="https://www.google.com/search?q=romeo+and+juliet">Romeo and Juliet (test)</a> into the source of a body field of a new page (assuming that the body field does not have 'taxonomy glossary' enabled yet)

Add "and" as a glossary term.

Save, and view the page, the result should be this:
Romeo and Juliet (test)

Enable taxonomy glossary on the body field of the relevant content type. And view the page again.

This time you will see this:
and+juliet">Romeo and Juliet (test).

The module has broken the link, and everthing after the 'and' in the URL is now plain text.

Proposed resolution

Do not apply the replacements within html tags.
Maybe do not apply the replacements within link text, as this clashes with what should happen when you click a link.

🐛 Bug report

Status

Version

4.0

Component

Code

Created by

🇬🇧United Kingdom jacobupal Leeds

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!9Replacement applies to URLs and breaks links
Open
🇦🇹Austria DrColossos
updated 8 months ago

Comments & Activities

Issue created by @jacobupal
First commit to issue fork.
Comment 9 months ago →
🇦🇹Austria DrColossos
Merge request !9Resolve #3378585 "Replacement applies to" → (Open) created by DrColossos
Status changed to Needs review 9 months ago8:44am 11 January 2024
Comment 9 months ago →
🇦🇹Austria DrColossos
I started working on this feature. The behavior is now the same as before but <a> and <img> get ignored. There are quite a few loops inside the function but I don't think that this affects performance.
Comment 4 months ago →
🇫🇷France mably
This looks like a major usability drawback, this should get merged as soon as possible.
Status changed to RTBC 4 months ago8:49pm 10 June 2024
Comment 4 months ago →
🇫🇷France mably
Comment 4 months ago →
🇫🇷France mably
@DrColossos it would be interesting to be able to exclude other tags like the heading ones (h1. h2, h3...).

May be we could make this configurable in some way.

And thanks for your great patch.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024