- Issue created by @Ronald van Belzen
- First commit to issue fork.
- Merge request !38Issue #3378238: Does Automated logout support CKEditor5? → (Merged) created by admirlju
- last update
about 1 year ago 15 pass, 7 fail - last update
about 1 year ago 15 pass, 7 fail - Status changed to Needs review
about 1 year ago 8:26am 20 September 2023 Just had to replace
CKEDITOR
withCKEditor5
. Testing by hand this looks like it fixes the problem. The failing automated tests look to be a combination of core migration issue 🌱 [META] Serialization issues in Migration tests Active and a few others that are being fixed in other submitted issues.So this needs a lot of testing by hand, so even if the tests are failing I'll set it to needs review.
- First commit to issue fork.
So it looks like there was a problem that CKEditor5 has lazy loading, thanks @DeaOm. This means the script loaded before CKEditor5 and all the logic was skipped.
In my testing, I figured out that if I add
keyup
event listener to the document, I also detectkeyup
inside CKEditor, since that event should also be counted as an activity I simply replaced the CKEditor5 logic with it.- Status changed to RTBC
about 1 year ago 1:23pm 29 September 2023 - 🇸🇮Slovenia DeaOm
Tested, and it detects when writing in the ckeditor5 and does not log me out, so marking this as RTBC, and once merged, Autologout will support ckeditro5, until then, it does not (to answer the OP question).
- First commit to issue fork.
-
jrglasgow →
committed acd2ac03 on 8.x-1.x authored by
admirlju →
Issue #3378238: Does Automated logout support CKEditor5?
-
jrglasgow →
committed acd2ac03 on 8.x-1.x authored by
admirlju →
- Status changed to Fixed
6 months ago 9:10pm 22 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.