Does Automated logout support CKEditor5?

Created on 31 July 2023, 11 months ago
Updated 5 June 2024, 15 days ago

It seems to me that the condition if (typeof CKEDITOR !== 'undefined') in autologout.js is not met when CKEditor5 is used.

💬 Support request
Status

Fixed

Version

1.0

Component

Code

Created by

🇳🇱Netherlands Ronald van Belzen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Ronald van Belzen
  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update 9 months ago
    15 pass, 7 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update 9 months ago
    15 pass, 7 fail
  • Status changed to Needs review 9 months ago
  • Just had to replace CKEDITOR with CKEditor5. Testing by hand this looks like it fixes the problem. The failing automated tests look to be a combination of core migration issue 🌱 [META] Serialization issues in Migration tests Active and a few others that are being fixed in other submitted issues.

    So this needs a lot of testing by hand, so even if the tests are failing I'll set it to needs review.

  • Pipeline finished with Success
    9 months ago
    Total: 362s
    #23752
  • First commit to issue fork.
  • Pipeline finished with Success
    9 months ago
    Total: 346s
    #24765
  • Pipeline finished with Success
    9 months ago
    Total: 383s
    #24953
  • So it looks like there was a problem that CKEditor5 has lazy loading, thanks @DeaOm. This means the script loaded before CKEditor5 and all the logic was skipped.

    In my testing, I figured out that if I add keyup event listener to the document, I also detect keyup inside CKEditor, since that event should also be counted as an activity I simply replaced the CKEditor5 logic with it.

  • Pipeline finished with Success
    9 months ago
    Total: 303s
    #25062
  • Status changed to RTBC 9 months ago
  • 🇸🇮Slovenia DeaOm

    Tested, and it detects when writing in the ckeditor5 and does not log me out, so marking this as RTBC, and once merged, Autologout will support ckeditro5, until then, it does not (to answer the OP question).

  • Pipeline finished with Skipped
    29 days ago
    #179717
  • First commit to issue fork.
  • Status changed to Fixed 29 days ago
  • 🇺🇸United States jrglasgow Idaho
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024