Submit buttons outside of actions do not work when inside steps

Open on Drupal.org →

Created on 31 July 2023, 11 months ago

Problem/Motivation

Submit buttons outside of actions (such as file field "Remove" buttons) do not work when inside steps because of the validate logic within the validateForm method in EntityFormSteps.php. One thing I noticed is that, because the form state is set to rebuild, the form no longer enters the core FormSubmitter to properly handle the pressed button (since it gets blocked on the following line within the core FormBuilder ProcessForm method: if (!$form_state->isRebuilding() && !FormState::hasAnyErrors()) {)

This issue also occurs with other buttons, such as multi entity reference "add more" buttons.

Proposed resolution

I fixed the issue for my site, by limiting the entity_form_steps validation to only occur on submits through buttons under "actions". A better solution might be to alter the way the validation works in general, if possible.

For now I will add a patch file for my solution in a following comment.

🐛 Bug report

Status

Fixed

Version

1.1

Component

Code

Created by

🇧🇪Belgium Chewi3

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @Chewi3
Comment 11 months ago →
🇧🇪Belgium Chewi3
Added patch with my temporary solution (as mentioned in issue description).
Comment 11 months ago →
🇧🇪Belgium Chewi3
Status changed to Needs review 11 months ago11:37am 31 July 2023
Comment 11 months ago →
🇳🇱Netherlands idebr

Comment 11 months ago →

c4fc332b committed on 1.x

Issue #3378155: Allow other triggering elements to rebuild the form.

Status changed to Fixed 11 months ago6:21pm 31 July 2023
Comment 11 months ago →
🇺🇸United States robphillips
Thanks for the report. Your submitted patch is changing way too much. Probably a difference in spaces versus tabs in your code editor. In any case, I was able to replicate the issue and implement the appropriate resolution.
Comment 11 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024