- Issue created by @Sunil Chaurasiya
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:24am 28 July 2023 - last update
over 1 year ago 3 pass - last update
over 1 year ago Composer error. Unable to continue. - last update
over 1 year ago run-tests.sh fatal error - 🇮🇳India mukhtarm
Verified and patch is applying cleanly. Once applied error is gone.
For more about the issue: https://www.drupal.org/project/announce_autosubmit/issues/3366097 🐛 jquery.once deprecated in D10 RTBC - 🇭🇷Croatia odisei
Just to confirm the patch is applying cleanly on 8.x-2.1, drupal 10.2.0
- Status changed to RTBC
12 months ago 1:24am 22 December 2023 - 🇺🇸United States tregonia
+1 RTBC
Confirming the patch is still good.Sidenote. This issue is a 100% blocker to a functioning module, but this patch gets it working again.
- 🇺🇸United States tregonia
While this patch does swap out the once syntax, it does not update the libraries to use the correct once dependency.
google_place_autocomplete: js: js/google_place_autocomplete.js: { } dependencies: - core/jquery - core/jquery.once - core/drupal - core/drupalSettings - google_place_autocomplete/google_maps.places
should become
google_place_autocomplete: js: js/google_place_autocomplete.js: { } dependencies: - core/jquery - core/drupal - core/once - core/drupalSettings - google_place_autocomplete/google_maps.places
Sidenote:
This issue is resolved in another way in 3414138 ✨ Remove dependency on jQuery Active - 🇻🇳Vietnam phannphong Ho Chi Minh City
On Drupal 10, we need this patch and the patch from the issue Google Places Autocomplete Not working Drupal 10 hook_field_widget_WIDGET_TYPE_form_alter is deprecated 🐛 Google Places Autocomplete Not working Drupal 10 hook_field_widget_WIDGET_TYPE_form_alter is deprecated RTBC to bring the modules works back.