- Issue created by @dinazaur
- @dinazaur opened merge request.
- 🇺🇦Ukraine dinazaur
Few notes about PR.
I've implemented a few adjustments so it's easier to add new features:
- For the notifications I've implemented a new plugin system, so it's much easier to add new notification types, and we don't repeat a lot of code. So right now we have a two notification plugins: sms, mail.
- All logic that was not related to plugins I've moved to the service
- Implemented ability to process all entities types inside tokens.
- Fixed bug inside scheduled notifier in case when from/to sid was "all". It was not working at all.
What's left to do is:
1. I don't know why we need two identical configuration entity types. We need to remove sms notifier entity and replace it with simple checkboxes for every plugin that is defined in the system inside WorkflowNotificationForm with additional field inside WorkflowNotification something like "notification_plugins". It will eliminate the tone of code.
2. To test sms notifications, I don't have time to do it at all. - Status changed to Needs review
over 1 year ago 4:28pm 11 August 2023