Focus disappears when tabbing through filter "buttons"

Created on 22 July 2023, over 1 year ago
Updated 8 November 2023, over 1 year ago

Problem/Motivation

The user can step through the filter "buttons" such as "Maintained" and "Covered by Security Policy", and pressing space will activate the "close" icon for the button, but there is no visual indication of which button has the focus.

Steps to reproduce

Select the "Search for modules" textbox, press tab. The focus will move to the first filter button, but there is no visual indication. Keep pressing tab, and after cycling through the buttons, the focus will reappear on "Clear filters".

Proposed resolution

Add a visual focus indication to the filter buttons.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
🐛 Bug report
Status

Closed: cannot reproduce

Version

1.0

Component

User experience

Created by

🇮🇪Ireland lostcarpark

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @lostcarpark
  • Assigned to libbna
  • 🇮🇳India libbna New Delhi, India
  • 🇺🇸United States chrisfromredfin Portland, Maine
  • 🇺🇸United States kurttrowbridge

    Hmm, I'm unable to reproduce this one (I tested in both Chrome and Safari on macOS Ventura). Screen recording attached of me (in Chrome) tabbing through the filters based on the described steps to reproduce—I see a focus indicator on the close button for each filter as I tab through, including after removing or adding filters. Am I misunderstanding anything, or is this all set already?

  • 🇩🇪Germany marcoliver Neuss, NRW, Germany

    I can second KurtTrowbridge's experience. Tested in Safari and Firefox on macOS, the reported behavior is not to be seen.

    @Libbna, can you maybe provide some more info on your testing environment (OS, browser)?

  • 🇮🇳India deborahblessy

    Tested the bug on MAC OS Sonoma. But I couldn't replicate this issue. Focus was working properly.

  • 🇮🇪Ireland lostcarpark

    I have tested in Firefox and Chromium on Linux. This was previously not showing any visual indication when the filter buttons had the focus. It now shows a green square around the X when it has the focus. It's not exactly how I'd expect a button to show it has the focus, but I agree there is a clear indication of which element has the focus.

    I'm still sure that this was happening, but it appears to have been fixed by other changes, so I think this could be closed.

  • Issue was unassigned.
  • 🇮🇳India libbna New Delhi, India
  • Status changed to Closed: cannot reproduce over 1 year ago
  • 🇩🇪Germany marcoliver Neuss, NRW, Germany

    Since multiple people, including the original author lostcarpark, were unable to reproduce the problem on the current module state, I'll go ahead and close this (as suggested by lostcarpark).

Production build 0.71.5 2024