- Issue created by @Spokje
- Status changed to Postponed
11 months ago 5:31am 22 July 2023 - 🇳🇱Netherlands Spokje
Postponing on the commit of 🐛 Ensure that edge caches are busted on deployments for css/js aggregates Fixed , so we can tackle
UnversionedAssetTest. - Status changed to Active
11 months ago 4:01pm 22 July 2023 - last update
11 months ago 29,879 pass - @spokje opened merge request.
- Status changed to Needs review
11 months ago 7:43am 23 July 2023 - 🇳🇱Netherlands Spokje
Tried to come up with a decent grep to see if there are more occurences of a pattern similar like this, but my grep-fu is weak and couldn't find any more then the ones in the MR.
- Status changed to RTBC
11 months ago 6:35pm 23 July 2023 - 🇺🇸United States smustgrave
The change looks good. Applied the MR and searched for xpath and seems they were all done in those files.
Should this be a larger meta though? Sure there could be tons of cleanups like this?
- Status changed to Fixed
11 months ago 8:10am 24 July 2023 - 🇬🇧United Kingdom catch
These tests are pretty new (added by me...) so it might just be I couldn't think of anything better at the time and we don't have more optimisations to make elsewhere. Given it's new-ish code going to go ahead and commit it, at minimum it'll stop those proliferating to more asset tests.
Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!
- 🇳🇱Netherlands Spokje
Yeah, as said, I searched for more occurences (or vaguely similar), but couldn't find any.
Not saying there _aren't_ any, but at least not very obvious. Automatically closed - issue fixed for 2 weeks with no activity.