Tighten xpath selectors to decrease complexity in tests

Created on 22 July 2023, over 1 year ago
Updated 24 July 2023, over 1 year ago

Problem/Motivation

In #3370828-75: Ensure that edge caches are busted on deployments for css/js aggregates @Chi discovered we can shave some complexity and time off in (at least) AssetOptimizationTest and UnversionedAssetTest by

+ if ($element->hasAttribute('href')) {

Can we drop this statement by including the condition directly into xpath. Something like '//link[@href and @rel="stylesheet"]'?

Steps to reproduce

Proposed resolution

- Tighten our xpath's in the tests mentioned above.
- See if this can be done in other tests.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.1

Component
PHPUnit 

Last updated about 13 hours ago

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024