Fix the issues reported by phpcs

Created on 21 July 2023, over 1 year ago

Problem/Motivation

FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/mailjet.routing.yml
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 37 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/mailjet.links.task.yml
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 23 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/mailjet.links.action.yml
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/config/schema/mailjet.schema.yml
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
 28 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/README.md
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 17 WARNINGS AFFECTING 17 LINES
---------------------------------------------------------------------------------------------
   8 | WARNING | Line exceeds 80 characters; contains 91 characters
  14 | WARNING | Line exceeds 80 characters; contains 82 characters
  24 | WARNING | Line exceeds 80 characters; contains 87 characters
  61 | WARNING | Line exceeds 80 characters; contains 87 characters
  63 | WARNING | Line exceeds 80 characters; contains 113 characters
  64 | WARNING | Line exceeds 80 characters; contains 87 characters
  79 | WARNING | Line exceeds 80 characters; contains 86 characters
  90 | WARNING | Line exceeds 80 characters; contains 95 characters
  94 | WARNING | Line exceeds 80 characters; contains 89 characters
  95 | WARNING | Line exceeds 80 characters; contains 93 characters
  96 | WARNING | Line exceeds 80 characters; contains 102 characters
  97 | WARNING | Line exceeds 80 characters; contains 92 characters
  98 | WARNING | Line exceeds 80 characters; contains 97 characters
 102 | WARNING | Line exceeds 80 characters; contains 95 characters
 112 | WARNING | Line exceeds 80 characters; contains 117 characters
 118 | WARNING | Line exceeds 80 characters; contains 120 characters
 155 | WARNING | Line exceeds 80 characters; contains 100 characters
---------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/mailjet.module
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 74 ERRORS AND 6 WARNINGS AFFECTING 72 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank line
   2 | ERROR   | [x] You must use "/**" style comments for a file comment
   7 | WARNING | [x] Unused use statement
  18 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('destination')
     |         |     instead
  33 | ERROR   | [ ] Description for the @return value is missing
  42 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
  42 | ERROR   | [ ] Description for the @return value is missing
  56 | ERROR   | [x] Expected 1 blank line after function; 2 found
  62 | ERROR   | [ ] Missing parameter comment
  64 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
  64 | ERROR   | [ ] Description for the @return value is missing
  66 | ERROR   | [ ] Type hint "unknown" missing for $infos
 123 | ERROR   | [x] Expected newline after closing brace
 140 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 141 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 142 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 143 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 144 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
 145 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 146 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 147 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 148 | ERROR   | [x] Expected newline after closing brace
 149 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 161 | WARNING | [x] A comma should follow the last multiline array item. Found: 'full'
 165 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 166 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 167 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 168 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
 169 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 170 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 177 | ERROR   | [x] Doc comment short description must end with a full stop
 179 | ERROR   | [ ] Missing parameter comment
 181 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
 181 | ERROR   | [ ] Description for the @return value is missing
 183 | ERROR   | [ ] Type hint "unknown" missing for $domain
 198 | WARNING | [ ] Only string literals should be passed to t() where possible
 204 | ERROR   | [x] Doc comment short description must end with a full stop
 206 | ERROR   | [ ] Missing parameter comment
 208 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
 208 | ERROR   | [ ] Description for the @return value is missing
 210 | ERROR   | [ ] Type hint "unknown" missing for $domain
 220 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 235 | WARNING | [ ] Unused variable $key.
 244 | ERROR   | [ ] Invalid function name, expected process_custom_fields but found processCustomFields
 244 | ERROR   | [x] Missing function doc comment
 245 | ERROR   | [x] Opening brace should be on the same line as the declaration
 250 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 256 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 266 | ERROR   | [x] Expected newline after closing brace
 266 | ERROR   | [x] Use "elseif" in place of "else if"
 268 | ERROR   | [x] Expected newline after closing brace
 268 | ERROR   | [x] Use "elseif" in place of "else if"
 285 | ERROR   | [x] Expected 1 blank line after function; 2 found
 298 | ERROR   | [x] Expected 1 blank line after function; 2 found
 327 | ERROR   | [x] Expected 1 blank line after function; 2 found
 383 | ERROR   | [ ] The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
 385 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 408 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 421 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 422 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 428 | ERROR   | [x] Missing function doc comment
 428 | ERROR   | [x] Expected 1 space after FUNCTION keyword; 2 found
 429 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 432 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 433 | ERROR   | [x] You must use "/**" style comments for a function comment
 436 | WARNING | [ ] Unused variable $mailjetApiClient.
 438 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 447 | ERROR   | [x] Missing function doc comment
 461 | ERROR   | [x] Missing function doc comment
 463 | ERROR   | [x] There must be no space before the colon in a CASE statement
 480 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 481 | ERROR   | [x] Case breaking statements must be followed by a single blank line
 490 | ERROR   | [x] Doc comment short description must end with a full stop
 504 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 507 | ERROR   | [x] Expected newline after closing brace
 513 | ERROR   | [x] Missing function doc comment
 553 | ERROR   | [x] Missing function doc comment
 561 | ERROR   | [x] Missing function doc comment
 571 | WARNING | [ ] Code after the RETURN statement on line 570 cannot be executed
 575 | ERROR   | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 62 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_event/mailjet_event.routing.yml
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_event/mailjet_event.install
-------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [x] There must be exactly one blank line after the file comment
 12 | ERROR | [x] Expected 1 blank line before function; 2 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_campaign/mailjet_campaign.install
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 26 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_campaign/mailjet_campaign.routing.yml
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
 7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_campaign/mailjet_campaign.module
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 26 ERRORS AND 1 WARNING AFFECTING 22 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
  18 | ERROR   | [x] Expected "Drupal\mailjet_signup_form_type\Entity\SignupForm" but found "Drupal\mailjet_signup_form_type\Entity\SignupForm;" for function return type
  21 | ERROR   | [x] Expected 1 blank line before function; 2 found
  36 | ERROR   | [ ] Type hint "array" missing for $campaign_ids
  52 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
  62 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  64 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  87 | ERROR   | [x] Expected newline after closing brace
  88 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  89 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  90 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 12
  91 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  92 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  92 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 113 | WARNING | [ ] Unused variable $k.
 119 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 129 | ERROR   | [x] Expected newline after closing brace
 147 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
 177 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 188 | ERROR   | [x] Comments may not appear after statements
 188 | ERROR   | [x] Inline comments must start with a capital letter
 188 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 190 | ERROR   | [ ] The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('data') instead
 198 | ERROR   | [x] Comments may not appear after statements
 198 | ERROR   | [x] Inline comments must start with a capital letter
 198 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 200 | ERROR   | [ ] The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('data') instead
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_campaign/src/Entity/Campaign.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------
  16 | ERROR   | [x] There must be a single blank line after a tag group
  34 | ERROR   | [x] Additional blank lines found at end of doc comment
  35 | ERROR   | [x] Expected 1 space before opening brace; found 2
  45 | ERROR   | [x] You must use "/**" style comments for a function comment
 122 | WARNING | [x] There must be no blank line following an inline comment
 122 | WARNING | [ ] There must be no blank line following an inline comment
 165 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_campaign/src/Controller/CampaignUninstallController.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank line
  2 | ERROR   | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
 11 | ERROR   | [x] Missing class doc comment
 13 | ERROR   | [x] Missing function doc comment
 16 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 20 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 23 | ERROR   | [x] Expected 1 blank line after function; 0 found
 24 | ERROR   | [x] The closing brace for the class must have an empty line before it
-----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_campaign/src/Controller/CampaignCallbackController.php
----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
  2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
 11 | ERROR | [x] Missing class doc comment
 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 13 | ERROR | [x] Missing function doc comment
 14 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 15 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 17 | ERROR | [x] Expected 1 newline at end of file; 0 found
 17 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_commerce/mailjet_commerce.install
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR   | [x] There must be exactly one blank line after the file comment
 12 | ERROR   | [x] Expected 1 blank line before function; 2 found
 33 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_commerce/mailjet_commerce.module
------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
 2 | ERROR | [x] You must use "/**" style comments for a file comment
 5 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 0
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_commerce/src/EventSubscriber/OrderCompleteSubscriber.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------
 33 | ERROR   | [x] Visibility must be declared on method "getSubscribedEvents"
 41 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 43 | ERROR   | [ ] Missing parameter comment
 43 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 55 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 61 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/modules/mailjet_commerce/src/EventSubscriber/InitSubscriber.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
 24 | ERROR | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('token') instead
 25 | ERROR | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('token') instead
----------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/mailjet.links.menu.yml
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 27 | ERROR | [x] Expected 1 newline at end of file; 5 found
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/src/Form/SubscribeEmailForm.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AND 3 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  82 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('list') instead
  83 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('list') instead
  85 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('sec_code') instead
  86 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('sec_code') instead
  88 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('properties') instead
  89 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('properties') instead
  91 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('others') instead
  92 | ERROR   | The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('others') instead
 152 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 152 | WARNING | Only string literals should be passed to t() where possible
 155 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/src/Form/MailjetApiForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  89 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 140 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 148 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/src/Form/DomainSaveForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 36 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 37 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 43 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 73 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/src/Form/MailjetTestEmailForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 38 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 40 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 58 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 59 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 73 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 77 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 78 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 86 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/src/Form/DomainSettingsForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 35 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 38 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 41 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 67 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/src/Form/MailjetSettingsForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 31 WARNINGS AFFECTING 32 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  44 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  61 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 115 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 121 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 127 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 133 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 139 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 155 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 162 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 169 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 176 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 183 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 190 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 197 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 204 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 211 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 212 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 232 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 283 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 289 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 301 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 305 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 321 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 332 | ERROR   | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
 334 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 337 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 350 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/src/Access/MailjetConfigurationAccessCheck.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 26 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 34 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 34 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 34 | ERROR   | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/src/Plugin/Mail/MailjetMail.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 5 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 136 | ERROR   | Parameter tags must be defined first in a doc comment
 191 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 206 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 310 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 498 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 519 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/Mailjet/src/MailjetBreadcrumbBuilder.php
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
 152 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------

Time: 1.23 secs; Memory: 16MB

Steps to reproduce

Please execute this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig Mailjet/

πŸ“Œ Task
Status

Closed: duplicate

Version

3.0

Component

Code

Created by

πŸ‡΅πŸ‡­Philippines roberttabigue

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024