Unset referenced variables after foreach loops

That looks like a useful tiny improvement, thank you for putting it together.

There's a tiny issue with the change - the indenting is incorrect, please re-save the change using two spaces for each indent so that it lines up correctly? Thank you.

Sorry for the wrong indenting, i think was a nano thing. Now i've made it with phpstorm and it seems right.

Let's extend this to fix similar issues in other parts of the codebase:

grep -r foreach|grep \&
./views_ui.module:  foreach ($plugins['display'] as &$display) {
./plugins/views_wizard/views_ui_base_views_wizard.class.php:            foreach ($path_fields as &$field) {
./plugins/views_wizard/views_ui_base_views_wizard.class.php:    foreach ($display_options as &$options) {
./plugins/views_wizard/views_ui_base_views_wizard.class.php:        foreach ($display_options['default']['fields'] as &$field) {
./plugins/views_plugin_style.inc:      foreach ($classes as &$class) {
./plugins/views_plugin_display.inc:      foreach ($filters as &$filter) {
./includes/admin.inc:    foreach ($new_fields as &$new_field) {
./includes/admin.inc:  foreach ($rows as &$row) {
./views.api.php:    foreach ($query->where as &$condition_group) {
./views.api.php:      foreach ($condition_group['conditions'] as &$condition) {
./views.api.php:  foreach ($commands as &$command) {
./theme/theme.inc:        foreach ($vars['rows'] as $num => &$column_items) {
./modules/comment/views_plugin_row_comment_rss.inc:    foreach ($this->comments as &$comment) {
./modules/field/views_handler_field_field.inc:      foreach ($values as $row_id => &$value) {
./modules/search/views_handler_filter_search.inc:        foreach ($condition_conditions as $key => &$condition) {
./modules/search/views_handler_filter_search.inc:      foreach ($conditions as $key => &$subcondition) {
./modules/search/views_handler_argument_search.inc:        foreach ($condition_conditions as $key => &$condition) {
./modules/system/views_handler_argument_file_fid.inc:    foreach ($titles as &$title) {
./modules/comment.views.inc:    foreach ($build as $cid => &$comment_build) {
./handlers/views_handler_field.inc:    foreach ($classes as &$class) {
./handlers/views_handler_field.inc:    foreach ($classes as &$class) {
./handlers/views_handler_field.inc:    foreach ($classes as &$class) {
./handlers/views_handler_filter_entity_bundle.inc:      foreach ($this->value as &$value) {
./handlers/views_handler_relationship_groupwise_max.inc:    foreach ($conditions as $condition_id => &$condition) {
./help/api-forms.html:    foreach ($this->view->result as $row_id => $row) {
./views.module:  foreach ($conditions as $condition_id => &$condition) {

@Carlitus: can you please review the new patch and let me know what you think? Thank you.

Hi,

I have checked it and I see everything is fine

The only thing is that I have seen some unused instances in the foreach keys, but maybe this is another minor issue.

comment.views.inc

line 708

    foreach ($build as $cid => &$comment_build) {
      if (isset($comment_build['links'])) {
        unset($comment_build['links']);
      }
    }
    unset($comment_build);

theme.inc

        foreach ($vars['rows'] as $num => &$column_items) {
          unset($column_items[$column]);
          unset($vars['header'][$column]);
        }
        unset($column_items);

I think it'd be better to do that cleanup separately.

Committed.

Automatically closed - issue fixed for 2 weeks with no activity.