Removal of the pattern matching requirement for URLs

Created on 21 July 2023, over 1 year ago

Updated 26 January 2024, 10 months ago

Problem/Motivation

The URL inputs include pattern matching to check if the URLs include "http://." and "https://." respectively. These fields can be inherited from the Matomo Analytics module but this module does not have this strict requirement which can cause the URL to not be applied correctly in some cases. Both modules share similar validation for the URLs other than the pattern matching thus it would be best to remove the pattern matching for the sake of consistency and stability.

Steps to reproduce

I you type in a URL starting with https:// in the http field on the Matomo Analytics module settings it is allowed but if you then automatically inherit the settings for the Matomo Reporting API it does not work because of the pattern matching.

Proposed resolution

Removal of the pattern matching from the settings form code. A patch has been created to do this.

📌 Task

Status

RTBC

Version

2.0

Component

Code

Created by

🇳🇱Netherlands roaldnel

Live updates comments and jobs are added and updated live.

finalist-sprint

Comments & Activities

Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
Waiting for branch to pass
Issue created by @roaldnel
Comment 10 months ago →
🇳🇱Netherlands batigolix Utrecht
Status changed to RTBC 10 months ago1:51pm 26 January 2024
Comment 10 months ago →
🇳🇱Netherlands arantxio Dordrecht
We have been using this fix for a while, and is the fix is only removing the line for the pattern is should be fine.

The fix is based on how they handle it within the Matomo module itself.

It is especially useful if you cannot use non encrypted connections.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024