Contrib.social

Removal of the pattern matching requirement for URLs

Open on Drupal.org →
Created on 21 July 2023, over 1 year ago

Problem/Motivation

The URL inputs include pattern matching to check if the URLs include "http://." and "https://." respectively. These fields can be inherited from the Matomo Analytics module but this module does not have this strict requirement which can cause the URL to not be applied correctly in some cases. Both modules share similar validation for the URLs other than the pattern matching thus it would be best to remove the pattern matching for the sake of consistency and stability.

Steps to reproduce

I you type in a URL starting with https:// in the http field on the Matomo Analytics module settings it is allowed but if you then automatically inherit the settings for the Matomo Reporting API it does not work because of the pattern matching.

Proposed resolution

Removal of the pattern matching from the settings form code. A patch has been created to do this.

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

🇳🇱Netherlands roaldnel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024